From owner-freebsd-arch@FreeBSD.ORG Mon Dec 11 23:24:20 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7356716A4A0; Mon, 11 Dec 2006 23:24:20 +0000 (UTC) (envelope-from jdp@polstra.com) Received: from blake.polstra.com (blake.polstra.com [64.81.189.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FFD843CC3; Mon, 11 Dec 2006 23:22:48 +0000 (GMT) (envelope-from jdp@polstra.com) Received: from strings.polstra.com (strings.polstra.com [64.81.189.67]) by blake.polstra.com (8.13.8/8.13.8) with ESMTP id kBBNNKNj029559; Mon, 11 Dec 2006 15:23:20 -0800 (PST) (envelope-from jdp@polstra.com) Message-ID: X-Mailer: XFMail 1.5.5 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200612110942.44308.jhb@freebsd.org> Date: Mon, 11 Dec 2006 15:23:20 -0800 (PST) From: John Polstra To: John Baldwin Cc: freebsd-arch@freebsd.org Subject: Re: Where do MSI quirks belong? [patch] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2006 23:24:20 -0000 On 11-Dec-2006 John Baldwin wrote: > Hmm. I did blacklist stuff several weeks ago but haven't had time to > test it or post it yet. :( Oops. :-} > I do think I like your approach a bit better though. What I had so > far is here: > > http://www.FreeBSD.org/~jhb/patches/msi_blacklist.patch > > I'm not sure if it's worth blacklisting MSI separate from MSI-X as that > only makes a difference at the device level (chipsets just get a single > memory write per interrupt either way, they can't tell MSI from MSI-X). Since the MSI support is really your turf, I'll happily defer to you on it. If you decide my patch should go in, I could add the additional blacklisted bridges from your patch, add the tunable to ignore the blacklist, and eliminate the distinction between blacklisting MSI and MSI-X. Let me know whether I should go ahead and commit that. John