From owner-freebsd-ports-bugs@freebsd.org Mon Nov 7 11:25:41 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35CD3C3490D for ; Mon, 7 Nov 2016 11:25:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 24158E7E for ; Mon, 7 Nov 2016 11:25:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uA7BPeZL048463 for ; Mon, 7 Nov 2016 11:25:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 213993] math/kmplot: fix for lang/gcc5 Date: Mon, 07 Nov 2016 11:25:41 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kennethsalerno@yahoo.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kde@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 11:25:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213993 Kenneth Salerno changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176421|0 |1 is obsolete| | --- Comment #7 from Kenneth Salerno --- Created attachment 176715 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D176715&action= =3Dedit view.cpp patch Patch as requested. Tested successfully with __MAKE_CONF=3D/dev/null (clang= ) and lang/gcc5. Note 1: Original source was already including cmath - no change there Note 2: By adding std::, the existing lines become unnecessary #if defined(Q_CC_MINGW) using namespace std; #endif Note 3: The reason clang++ does not need std:: to call isnan/isinf in scope is beca= use LLVM's /usr/include/c++/v1/cmath has "using ::isnan/::isinf" defined as wel= l as namespace std { }. Either patch version will work, I just think my patch would have been easie= r to maintain than touching view.cpp on so many lines that could get adjusted in future releases and be a headache. --=20 You are receiving this mail because: You are on the CC list for the bug.=