From owner-svn-src-stable-12@freebsd.org Tue Feb 12 01:18:56 2019 Return-Path: Delivered-To: svn-src-stable-12@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1192E14EAC2A; Tue, 12 Feb 2019 01:18:56 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-it1-f175.google.com (mail-it1-f175.google.com [209.85.166.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 97CBF93770; Tue, 12 Feb 2019 01:18:55 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-it1-f175.google.com with SMTP id z20so3342174itc.3; Mon, 11 Feb 2019 17:18:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bUT6jRd87+jgAnWEkVU9v2Q8yYRH8dMEl6vT/m6BHyg=; b=hoMUfBDA8kZowbd+TixM1Btv5VKLLXVmqJkz2R93Jg93moiwsuwSwt3FGO/cpX4u1Y ZOpR+oNAanUyD5MP93qUstV2eci76utdqFS/y9gBgVfT5u0SFfW8TYM+jvVzT1bFV9Au NA+tWnKZhPWfdigWp0NWy9QlZ/lMFMYyB8bORwbKjP9hjLg/0iAnrYESTuwPClD/4o+A TDAR7djHqsC+yhOI/lEDPiGOX6p7O2ZdrDHFES0vhWgj+hLGZZu7o3yKCJjQPdZbXwUI c7gPo7Y06AKjOpcVqAnwSoqajS3klUbHJomcigiNDaH/Fe5PUQJ2MrpP1uu1+uBLkzhy 53ug== X-Gm-Message-State: AHQUAuboKw5QugpCCvSdp8kTqhmDPucG2YQ/JM0rIKBqbX6AvxmC/rKC Eg2Jh+10D/qu2tgQPgpR2JLh7fhsYImkGlkmO1DHtw== X-Google-Smtp-Source: AHgI3IYDXzooB0bqa5SKbyNitXYjhGIb8wjbRLgHX6kKZ4Bs4HKLl/Fs9A3Qf+m+PcYPfT3HJb03wtjPsyse2YnKzuI= X-Received: by 2002:a24:5f4c:: with SMTP id r73mr681941itb.25.1549934009334; Mon, 11 Feb 2019 17:13:29 -0800 (PST) MIME-Version: 1.0 References: <201902120026.x1C0Q1FW073337@pdx.rh.CN85.dnsmgr.net> <62d2dcc1-5bde-1eda-6d9f-82138932cb36@FreeBSD.org> In-Reply-To: <62d2dcc1-5bde-1eda-6d9f-82138932cb36@FreeBSD.org> From: Patrick Kelsey Date: Mon, 11 Feb 2019 20:13:16 -0500 Message-ID: Subject: Re: svn commit: r344027 - in stable/12/sys: dev/vmware/vmxnet3 modules/vmware/vmxnet3 net To: John Baldwin Cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org X-Rspamd-Queue-Id: 97CBF93770 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.88 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_SHORT(-0.89)[-0.887,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 01:18:56 -0000 On Mon, Feb 11, 2019 at 8:08 PM John Baldwin wrote: > On 2/11/19 4:26 PM, Rodney W. Grimes wrote: > >> Author: pkelsey > >> Date: Mon Feb 11 23:24:39 2019 > >> New Revision: 344027 > >> URL: https://svnweb.freebsd.org/changeset/base/344027 > >> > >> Log: > >> MFC r343291: > >> Convert vmx(4) to being an iflib driver. > > > > I strongly object to this MFC, given the current number > > of 12.0 RELEASE related iflib problems we have it is > > foolish of us to iflib any more drivers in 12.0 > > This isn't the release branch though and presumably we have some time > before > 12.1 ships. If there are reports of vmx(4) breakage on stable before 12.1 > we could always revert this commit then? > > I've heard of some EN's for 12.0 for iflib fixes. Are those fixes in > stable/12 > yet or are we still waiting for them to land in HEAD and/or be merged? > iflib.c is currently the same between head and stable/12. I've found and fixed a number of iflib bugs by developing the iflib version of the vmx(4) driver, and it's also being fielded in a product. I'm also aware that not all current driver problems are necessarily iflib problems. I think we'd be better off letting this version of vmx(4) ride it out in stable/12 until such time as we discover an actual horror that we then feel we need to react to in some way other than just going ahead and fixing it. -Patrick