From owner-svn-src-all@FreeBSD.ORG Fri Jun 12 07:07:42 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B3F21065678 for ; Fri, 12 Jun 2009 07:07:42 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outV.internet-mail-service.net (outv.internet-mail-service.net [216.240.47.245]) by mx1.freebsd.org (Postfix) with ESMTP id 5DA3A8FC17 for ; Fri, 12 Jun 2009 07:07:42 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id F2C4ECD467; Fri, 12 Jun 2009 00:08:01 -0700 (PDT) X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id 83CA62D6004; Fri, 12 Jun 2009 00:07:41 -0700 (PDT) Message-ID: <4A31FEBD.6020601@elischer.org> Date: Fri, 12 Jun 2009 00:07:41 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302) MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200906111650.n5BGonnn053446@svn.freebsd.org> <20090611190140.GE2642@garage.freebsd.pl> In-Reply-To: <20090611190140.GE2642@garage.freebsd.pl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Marko Zec Subject: Re: svn commit: r194012 - in head: . sys/netgraph sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2009 07:07:43 -0000 Pawel Jakub Dawidek wrote: > Are you sure Marko that you can't use sys/sys/osd.h instead of adding > yet another field to the thread structure? Netgraph is optional > component and optional components could take advantage of allocating > stuff they need dynamically. The OSD (Object-Specific Data) KPI is > designed for use by optional components - you can add your data to a > thread, you can get it when you want and OSD will call your callback > when thread dies, so you can clean up. > > Maybe you can't, but it's worth checking. > > PS. Currently OSD works for threads and jails, but it is ready to be > extended to work with other object types, eg. vnodes, ifnets, etc. > Even if you can't use it in this particular case, keep it in mind, > as it might be useful for other vimage-related stuff. > BTW Having a quick look around I don't see a man page for osd, and I'd never looked at it until today, nor even really heard of it. (except I saw jamie used it for something). if the include page is the main documentation then it need some comments.