From owner-freebsd-apache@FreeBSD.ORG Sun Aug 12 22:57:37 2012 Return-Path: Delivered-To: freebsd-apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AB905106567A; Sun, 12 Aug 2012 22:57:37 +0000 (UTC) (envelope-from ohauer@FreeBSD.org) Received: from p578be941.dip0.t-ipconnect.de (p578be941.dip0.t-ipconnect.de [87.139.233.65]) by mx1.freebsd.org (Postfix) with ESMTP id 4134C8FC1B; Sun, 12 Aug 2012 22:57:37 +0000 (UTC) Received: from [192.168.0.100] (cde1100.uni.vrs [192.168.0.100]) (Authenticated sender: ohauer) by p578be941.dip0.t-ipconnect.de (Postfix) with ESMTPSA id 7F1092087E; Mon, 13 Aug 2012 00:57:36 +0200 (CEST) Message-ID: <502834EB.8030300@FreeBSD.org> Date: Mon, 13 Aug 2012 00:57:47 +0200 From: Olli Hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: freebsd-apache@freebsd.org References: <201208112122.q7BLMn3g037694@gateway.ipv6.occnc.com> <50282D58.5070605@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Philip M. Gollucci" Subject: Re: patch to apache for IPv6 only httpd X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "apache@FreeBSD.org" List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2012 22:57:37 -0000 On 2012-08-13 00:27, Philip M. Gollucci wrote: > This needs to be sent back to dev@httpd.apache.org for upstream commit. > This shouldn't be a permenant local > fbsd patch. OK, should I include the patch as extra patch if apache is build with -DWITH_IPV6_V6ONLY ? I can do this with the commit for the rewritten bsd.apache.mk. But I full agree, the fix should go upstream. -- olli > > On Sun, Aug 12, 2012 at 6:25 PM, Olli Hauer wrote: > >> On 2012-08-11 23:22, Curtis Villamizar wrote: >>> FYI- >>> >>> This very simple patch prevents an assert when httpd is run on a >>> server that has no IPv4 address. An example is a BSD jail running >>> with only an IPv6 address on the interface (no loopback so no >>> 127.0.0.1 address to bind to). >>> >>> Copy the patch below into the files directory as >>> /usr/ports/www/apache22/files/patch-server__config.c >>> >>> The port maintainer is on the Cc. No bug has been reported. >>> >>> BTW- I noticed this a long time ago. I don't remember if I reported >>> it or forgot to. Appologies if this is a duplicate. It is not in the >>> httpd-2.2.22.tar.bz2 tarball, in the distinfo dated 23 July 2012. >>> >>> Curtis >>> >>> >>> --- ./server/config.c.orig 2010-10-07 09:56:54.000000000 -0700 >>> +++ ./server/config.c 2011-09-26 21:20:35.000000000 -0700 >>> @@ -1979,6 +1979,9 @@ >>> /* NOT virtual host; don't match any real network interface */ >>> rv = apr_sockaddr_info_get(&s->addrs->host_addr, >>> NULL, APR_INET, 0, 0, p); >>> + if (rv != APR_SUCCESS) >>> + rv = apr_sockaddr_info_get(&s->addrs->host_addr, >>> + NULL, APR_UNSPEC, 0, 0, p); >>> ap_assert(rv == APR_SUCCESS); /* otherwise: bug or no storage */ >>> >>> s->addrs->host_port = 0; /* matches any port */ >> >> Hi Curtis, >> >> Is this patch also relevant if apache22 was build with >> -DWITH_IPV6_V6ONLY ? >> >> -- >> olli >> _______________________________________________ >> freebsd-apache@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-apache >> To unsubscribe, send any mail to "freebsd-apache-unsubscribe@freebsd.org" >> > > >