From owner-dev-commits-src-main@freebsd.org Sat Jan 9 18:56:22 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BEACD4DFE76; Sat, 9 Jan 2021 18:56:22 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCq1y3Q4Fz3sLS; Sat, 9 Jan 2021 18:56:21 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id D981C2600D9; Sat, 9 Jan 2021 19:56:13 +0100 (CET) Subject: Re: git: 82c7abe7785b - main - The "unsigned" type is the same like "unsigned int". To: Andriy Gapon , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202101081137.108Bbs7N013971@gitrepo.freebsd.org> <1d08f668-bd19-dd77-01b8-e138209865d9@uabsd.com> From: Hans Petter Selasky Message-ID: <12943359-e2fc-2a5d-6cbe-fe0d7093eb42@selasky.org> Date: Sat, 9 Jan 2021 19:56:03 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <1d08f668-bd19-dd77-01b8-e138209865d9@uabsd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DCq1y3Q4Fz3sLS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2021 18:56:22 -0000 On 1/9/21 7:15 PM, Andriy Gapon wrote: > On 2021-01-08 13:37, Hans Petter Selasky wrote: >> The branch main has been updated by hselasky: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=82c7abe7785bd8aeb290d91f80ddeb31e81407a5 >> >> commit 82c7abe7785bd8aeb290d91f80ddeb31e81407a5 >> Author: Hans Petter Selasky >> AuthorDate: 2021-01-08 10:58:10 +0000 >> Commit: Hans Petter Selasky >> CommitDate: 2021-01-08 11:35:54 +0000 >> >> The "unsigned" type is the same like "unsigned int". >> >> MFC after: 1 week >> Sponsored by: Mellanox Technologies // NVIDIA Networking >> --- >> sys/dev/mlx5/mlx5_core/mlx5_main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sys/dev/mlx5/mlx5_core/mlx5_main.c b/sys/dev/mlx5/mlx5_core/mlx5_main.c >> index d0b4027165ea..40cba09106f0 100644 >> --- a/sys/dev/mlx5/mlx5_core/mlx5_main.c >> +++ b/sys/dev/mlx5/mlx5_core/mlx5_main.c >> @@ -708,7 +708,7 @@ static int wait_fw_init(struct mlx5_core_dev *dev, u32 max_wait_mili, >> if (warn_time_mili && time_after(jiffies, warn)) { >> mlx5_core_warn(dev, >> "Waiting for FW initialization, timeout abort in %u s\n", >> - (unsigned int)(jiffies_to_msecs(end - warn) / 1000)); >> + (unsigned)(jiffies_to_msecs(end - warn) / 1000)); > > I am not sure that we actually prefer "unsigned" over "unsigned int". > If you just wanted to make the line a bit shorter then u_int is what is > typically used in FreeBSD code. > I just wanted to reduce diffs with internal code. --HPS