From owner-freebsd-testing@FreeBSD.ORG Tue Oct 29 20:59:49 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7F636279 for ; Tue, 29 Oct 2013 20:59:49 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from ch1outboundpool.messaging.microsoft.com (ch1ehsobe003.messaging.microsoft.com [216.32.181.183]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2D8CD26CC for ; Tue, 29 Oct 2013 20:59:48 +0000 (UTC) Received: from mail101-ch1-R.bigfish.com (10.43.68.227) by CH1EHSOBE009.bigfish.com (10.43.70.59) with Microsoft SMTP Server id 14.1.225.22; Tue, 29 Oct 2013 20:59:42 +0000 Received: from mail101-ch1 (localhost [127.0.0.1]) by mail101-ch1-R.bigfish.com (Postfix) with ESMTP id DA6863A00A5; Tue, 29 Oct 2013 20:59:41 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.224.54; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF01-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: 1 X-BigFish: VPS1(zz146fI1432Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6h1082kzz1de097hz2fh2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h2218h2216h1155h) Received-SPF: pass (mail101-ch1: domain of juniper.net designates 66.129.224.54 as permitted sender) client-ip=66.129.224.54; envelope-from=sjg@juniper.net; helo=P-EMF01-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail101-ch1 (localhost.localdomain [127.0.0.1]) by mail101-ch1 (MessageSwitch) id 1383080380375585_14777; Tue, 29 Oct 2013 20:59:40 +0000 (UTC) Received: from CH1EHSMHS040.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.241]) by mail101-ch1.bigfish.com (Postfix) with ESMTP id 46D43380033; Tue, 29 Oct 2013 20:59:40 +0000 (UTC) Received: from P-EMF01-SAC.jnpr.net (66.129.224.54) by CH1EHSMHS040.bigfish.com (10.43.69.249) with Microsoft SMTP Server (TLS) id 14.16.227.3; Tue, 29 Oct 2013 20:59:39 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMF01-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Tue, 29 Oct 2013 13:59:37 -0700 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id r9TKxaL19590; Tue, 29 Oct 2013 13:59:36 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id 0C1905807E; Tue, 29 Oct 2013 13:59:36 -0700 (PDT) To: Julio Merino Subject: Re: Plugging ATF tests into the build and other cleanups In-Reply-To: References: Comments: In-reply-to: Julio Merino message dated "Sun, 27 Oct 2013 21:31:12 -0400." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Tue, 29 Oct 2013 13:59:36 -0700 Message-ID: <20131029205936.0C1905807E@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: freebsd-testing@freebsd.org, Rui Paulo , sjg@juniper.net X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Oct 2013 20:59:49 -0000 On Sun, 27 Oct 2013 21:31:12 -0400, Julio Merino writes: >revisit this, although I'm not sure how you can easily determine the >list of "current tests". AFAIK there is no list in src detailing all >files that are expected to be installed? So I know this probably doesn't help but.... As I think I've mentioned in our build, we build tests and stage them automatically to a stage tree ($SB/obj/stage/$MACHINE/usr/tests/...) unless building for the pseudo machine 'host' in which case the tests are run in-place as part of the build - tests fail, build fails. Anyway, before the makefile that does "packaging" for the tests, another does a scan of $SB/obj/stage/$MACHINE/usr/tests/ to find all the tests and build the manifest that will be used for them. This avoids having to maintain a list, and makes adding tests trivial. >My concern is only about the latter at the moment. When MK_TESTS=no, >/usr/tests should not exist at all and, therefore, a "make >delete-old-files" should wipe it. We can do this as usual, with the Obviously this really only matters if/when one does 'make delete-old-files -DWITHOUT_TESTS' >functionality in tools/build/mk/OptionalObsoleteFiles.inc to record >all files to be deleted, or we can do something different to avoid >maintaining the list by hand. A simple "rm -rf ${DESTDIR}/usr/tests" >would suffice, but I'm just wondering if that'd be an acceptable thing >to do. Not quite within the context of delete-old-files given the way it works, but doesn't mean one couldn't add delete-old-dirs-rmrf with its own list for input eg. OLD_DIRS_RMRF >> We would need some way to have "local" tests but that should not be difficul >t? > >You mean tests from ports and/or for manually installed software? >Those should all be somewhere in /usr/local/ and we can easily hook >them into the test suite. (Hadn't thought about these, but it's >easy.) The model I mentioned above "just works" in this case. Not much help though until using all the goodies on projects/bmake (the above isn't there either yet - hope to fix that soon).