Date: Sun, 23 Nov 2003 02:32:08 +0100 From: "Simon L. Nielsen" <simon@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: doc@FreeBSD.org Subject: Re: Localized mirror names Message-ID: <20031123013206.GA399@arthur.nitro.dk> In-Reply-To: <20031122.215345.41660717.hrs@eos.ocn.ne.jp> References: <61204080291.20031117100651@alexdupre.com> <20031117.194741.39704906.hrs@eos.ocn.ne.jp> <20031122.215345.41660717.hrs@eos.ocn.ne.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2003.11.22 21:53:45 +0900, Hiroki Sato wrote:
> Hi all,
>=20
> I made a new patchset to brush up mirrors.xml and resolve sort order
> problem in localized documents. In addition, to make mirrors.xml
> usable from doc/ and www/, some structural changes are included.
> The main components are:
In general it looks really good, but (of course :) ) I have some
comments:
In www/ja/includes.xsl you seem to have some commented out text that
looks leftover and could just be removed e.g.:
> +<!--
> <xsl:variable name=3D"u.rel.notes">
> <xsl:value-of select=3D"$base"/>/releases/<xsl:value-of select=3D"$r=
el.current"/>R/relnotes.html</xsl:variable>
> +-->
In www/share/mk/web.site.mk:
> @@ -77,6 +77,31 @@
> #
> NO_SUBDIR=3D YES
> =20
> +#
> +# for dependency
> +#
> +
> +XML_NEWS=3D ${.CURDIR}/news/news.xml
> +XML_NEWS+=3D ${.CURDIR}/news/press.xml
> +XML_NEWS+=3D ${.CURDIR}/news/includes.xsl
Shouldn't theese also use WEB_PREFIX or some other prefix so it works in
other directories than www/<lang>/ ? This is not too important though.
The doc/share/mk/doc.images.mk file has the A4 workaround, which should
probably be commited seperatly?
In README.mirrors the first two indented sections are indented with one
space, and the rest with two - I think all should just be indented with
two.
BTW, I think the text in README.mirrors would be a good candidate to be
moved into the FDP Primer at some point.
There seems to have slipped an extra close parenthesis in
doc/ja_JP.eucJP/share/sgml/transtable.xml :
> @@ -1,4 +1,18 @@
> <?xml version=3D"1.0" encoding=3D"euc-jp"?>
> +<!-- $FreeBSD$ -->
> +
> +<!--
> +
> + This is a translation table used in transtable-master.xsl.
> + For example:
> +
> + <word>
> + <orig>word in English)</orig>
^
> + <tran>word in your language</tran>
> + </word>
> +
> +-->
Typo :
> Index: doc/share/mk/doc.project.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/dcvs/doc/share/mk/doc.project.mk,v
> retrieving revision 1.15
> diff -d -u -I\$FreeBSD:.*\$ -I\$NetBSD:.*\$ -I\$OpenBSD:.*\$ -I\$Id:.*\$ =
-I\$hrs:.*\$ -r1.15 doc.project.mk
> --- doc/share/mk/doc.project.mk 1 Aug 2003 20:28:55 -0000 1.15
> +++ doc/share/mk/doc.project.mk 20 Nov 2003 05:03:35 -0000
> @@ -48,6 +48,9 @@
> # doc.subdir.mk Subdirectory related configuration, including
> # handling "obj" builds.
> #
> +# doc.commom.mk targets and variables commonly used in doc/ and
^ n
> +# www/ tree.
> +#
There are some EOL whitespace in: www/share/sgml/includes.header.xsl,
www/share/sgml/includes.release.xsl, doc/share/mk/doc.common.mk,
doc/share/sgml/README.mirrors, and doc/share/sgml/transtable-master.xsl.
I know some of the EOL whitepsace are just from text you have
copy/pasted, but now seem a good time to get rid of it, when it's being
moved anyway.
BTW. if you use emacs I would recomend using '(setq-default
show-trailing-whitespace t)' in your .emacs file.
> doc/share/sgml/transtable-{local,master}.xsl
> translates .xml file using transtable.xml.
>=20
> doc/share/sgml/transtable.xml
> a translation table.
I must say that I really like the transtable - seams to be a neat way to
handle it :-).
> Could anyone please try and/or review this?
Go for it!
The test builds I made all worked fine.
--=20
Simon L. Nielsen
FreeBSD Documentation Team
--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQE/wA4Wh9pcDSc1mlERAqsCAJ9El8GFiewQxmsu+dPOLfT31Yf84gCfXEIB
NJwuDnAYXecEz/OoaqdZTww=
=ArxT
-----END PGP SIGNATURE-----
--pWyiEgJYm5f9v55/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031123013206.GA399>