From owner-svn-src-head@FreeBSD.ORG Mon Feb 24 08:34:33 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 23CEE531; Mon, 24 Feb 2014 08:34:33 +0000 (UTC) Received: from mail-la0-x22f.google.com (mail-la0-x22f.google.com [IPv6:2a00:1450:4010:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1796E175E; Mon, 24 Feb 2014 08:34:31 +0000 (UTC) Received: by mail-la0-f47.google.com with SMTP id y1so853964lam.20 for ; Mon, 24 Feb 2014 00:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=yksMyufAW8Z0X2dVXzVUQxA4CpU8KoSJ8B6STmGKiT4=; b=xFgXFLOdvMAkDeMKSjchIx2UfT0RysJFRMP+Mq9en2NdlpBa5gy4onHaWmW/zd2Opn A9Pykyue/rwzMxRdWL4UIyqYw/yMvlhLpa8uyfovMHhYIWzc6NL0SUbNYKWIb/tKka2a tZVT3KtES6YYaHNxeOGBwgFyGYEe2yhlxpPdnap6UV0hR+YHpcaW0S0vwNGOXz5Cysd2 5leIWhJ/W1L+IhRmrTQ686Nzm5cqVRyg4thAcv48NWdRMhGYVZM4yn2/JpCt1e7YgqKg 2DXVzFcsE48HLct6gFKzxG/LvUPvzNoXn377+wzZnXCrehQGMpMFmlDuZNmFJU2cGdVn fHaA== MIME-Version: 1.0 X-Received: by 10.113.3.43 with SMTP id bt11mr10861255lbd.92.1393230868404; Mon, 24 Feb 2014 00:34:28 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.112.30.211 with HTTP; Mon, 24 Feb 2014 00:34:28 -0800 (PST) Received: by 10.112.30.211 with HTTP; Mon, 24 Feb 2014 00:34:28 -0800 (PST) In-Reply-To: References: <201402230127.s1N1RMoX052542@svn.freebsd.org> Date: Mon, 24 Feb 2014 00:34:28 -0800 X-Google-Sender-Auth: wfZ2jNtBsB5rH7nehHzd-obP4cc Message-ID: Subject: Re: svn commit: r262351 - head/sys/netinet6 From: Craig Rodrigues To: "Bjoern A. Zeeb" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2014 08:34:33 -0000 On Feb 23, 2014 2:56 PM, "Bjoern A. Zeeb" wrote: > > > On 23 Feb 2014, at 01:27 , Craig Rodrigues wrote: > > > Author: rodrigc > > Date: Sun Feb 23 01:27:22 2014 > > New Revision: 262351 > > URL: http://svnweb.freebsd.org/changeset/base/262351 > > > > Log: > > Remove KASSERT from in6p_lookup_mcast_ifp(). > > > > When the devel/jenkins port, version 1.551 was started, > > the kernel would panic if INVARIANTS was enabled in the kernel config. > > > > Suggested by: bms > > This reads to me "we hit the assert, bms suggested to remove it". Great! Caught a bug! Where is it? In no way the commit message tells me why? Why did we not hit the assert in the last n years? What has changed that we hit it now? Was the assert wrong from the beginning? Did we hit a real bug elsewhere and now lost the tracking for it? > > Could you please at least for the archives explain? Bruce suggested that I remove the KASSERT here: http://lists.freebsd.org/pipermail/freebsd-net/2013-October/036806.html -- Craig