From owner-svn-src-all@freebsd.org Mon Jun 3 13:54:38 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C03315B1C4A; Mon, 3 Jun 2019 13:54:38 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8A3738164B; Mon, 3 Jun 2019 13:54:37 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x53DsV3I043189; Mon, 3 Jun 2019 06:54:31 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x53DsV3X043188; Mon, 3 Jun 2019 06:54:31 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201906031354.x53DsV3X043188@gndrsh.dnsmgr.net> Subject: Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb In-Reply-To: <201906031147.x53Blc0b013004@slippy.cwsent.com> To: Cy Schubert Date: Mon, 3 Jun 2019 06:54:31 -0700 (PDT) CC: Andrew Turner , Maxim Sobolev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 8A3738164B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.941,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 13:54:38 -0000 > In message <7BD6B7AD-5950-4015-B95D-9FFB609F51E9@fubar.geek.nz>, Andrew Turner > writes: > > > > > > > On 3 Jun 2019, at 00:38, Maxim Sobolev wrote: > > > > > > Author: sobomax > > > Date: Sun Jun 2 23:38:19 2019 > > > New Revision: 348521 > > > URL: https://svnweb.freebsd.org/changeset/base/348521 > > > > > > Log: > > > Fix several places where tool name has been hardcoded: > > > > > > install -> ${INSTALL} > > > mtree -> ${MTREE_CMD} > > > services_mkdb -> ${SERVICES_MKDB_CMD} > > > cap_mkdb -> ${CAP_MKDB_CMD} > > > pwd_mkdb -> ${PWD_MKDB_CMD} > > > kldxref -> ${KLDXREF_CMD} > > > > > > If you do custom FreeBSD builds you may want to override those > > > in some cases. > > > > > > Sponsored by: Sippy Software, Inc. > > > > This breaks installworld in a local Jenkins instance. I???m building with -DD > > B_FROM_SRC and -DNO_ROOT. It looks like INSTALL is unset. > > > > Andrew > > > > -------------------------------------------------------------- > > >>> Making hierarchy > > -------------------------------------------------------------- > > cd /jenkins/workspace/FreeBSD-arm64-head/freebsd-head; make -f Makefile.inc1 > > LOCAL_MTREE= hierarchy > > cd /jenkins/workspace/FreeBSD-arm64-head/freebsd-head/etc; PATH=/jenkins/work ... > > It also breaks poudirere builds at make distrib-dirs, amd64 and i386, i386 > distrib-dirs on amd64 sample below. The src/etc/Makefile distrib-dirs target > is the failing one. Something is pretty broke here then, as INSTALL has been defined for ever in sys.mk: sys.mk:INSTALL ?= install -- Rod Grimes rgrimes@freebsd.org