From owner-svn-src-head@FreeBSD.ORG Mon May 11 00:45:21 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3F49F6BB for ; Mon, 11 May 2015 00:45:21 +0000 (UTC) Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com [IPv6:2a00:1450:400c:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C57BC10E7 for ; Mon, 11 May 2015 00:45:20 +0000 (UTC) Received: by wizk4 with SMTP id k4so86750437wiz.1 for ; Sun, 10 May 2015 17:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=S0KnkqwQIOQuTnhFKX0hm+4IqjSYsONHoPdUsXv2IpE=; b=K9wNTpEQuvlSO6fPJ2aVr2JcHWLCehP/in7tVyeyHmYrdtdCwl5Nx77ZtHHMruLX0X EGdHqaWaemYIJ2wxGXvhKGLoHzETtFAeTdEoLFcy8+tCZJS/OnKb1GAQS6fYp9LZ+sAz H1l7jHhPJytzON7fTQIpS8ygpBEx/HuqUVYrg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=S0KnkqwQIOQuTnhFKX0hm+4IqjSYsONHoPdUsXv2IpE=; b=ErvWUo/UVrL3okoljiPJQWnscFUVOdT5cOM47Ki5IxY+Lk7KV+3dt/xJs65Rgyq5XV QplxUrVVzx3P96fUwWwmU4nxjxD/Oi1PcJ62zmi6vB341dm8fjscBJ+iyFNgSFlxwLG9 R/7UL7fEdD4K0wuIdzt7G95UA3kGswr+AOh/e28au6m5oYvQqsm01wh46kNKXxWvLb/Y F4yMiIe1GUZmdgV9rkdDUnjambqIfeaBKWpZ+auKbMpsBJxEnm3j4PX73U+wKqu07HTc Zpv7SzvyTPCV7Z2eiis4zVy1APCOp4kkTF6rXNkXGBVlh01ZSD4UghpVBSf0ipjWoK8b FNqw== X-Gm-Message-State: ALoCoQk1XMIrZx62jRLMPas5oR+bndRVQQjy05GUVcflqXHYqbw9JZRYbIltPhJE8d3o4P60QLLk X-Received: by 10.180.92.161 with SMTP id cn1mr15729001wib.91.1431305119113; Sun, 10 May 2015 17:45:19 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.28.20.75 with HTTP; Sun, 10 May 2015 17:44:48 -0700 (PDT) In-Reply-To: References: <201505082336.t48NaWRS080408@svn.freebsd.org> From: Eitan Adler Date: Sun, 10 May 2015 17:44:48 -0700 X-Google-Sender-Auth: rCNNcYQFsQR-ix5ygBfyScmUwBE Message-ID: Subject: Re: svn commit: r282672 - head/etc/rc.d To: John Baldwin Cc: Xin LI , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 00:45:21 -0000 On 10 May 2015 at 12:45, John Baldwin wrote: > >> On May 8, 2015, at 19:36, Xin LI wrote: >> >> Author: delphij >> Date: Fri May 8 23:36:31 2015 >> New Revision: 282672 >> URL: https://svnweb.freebsd.org/changeset/base/282672 >> >> Log: >> Always convert uuid to lower case. >> >> MFC after: 2 weeks >> >> Modified: >> head/etc/rc.d/hostid >> >> Modified: head/etc/rc.d/hostid >> ============================================================================== >> --- head/etc/rc.d/hostid Fri May 8 23:29:42 2015 (r282671) >> +++ head/etc/rc.d/hostid Fri May 8 23:36:31 2015 (r282672) >> @@ -58,7 +58,7 @@ hostid_set() >> >> valid_hostid() >> { >> - uuid=$1 >> + uuid=$(echo $1 | tr '[:upper:]' '[:lower:]') > > tr is in /usr/bin so this breaks systems with a separate /usr. Perhaps you could use dd with conv=lcase instead? FWIW this broke hostid on my system, causing zfs to refuse to import one of my pools. In particular the lack of tr caused hostid to fail entirely, causing the hostid to change each time. Is there a reason that the uuid has to be lowercase in the first place? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams