From nobody Sat Oct 9 06:18:48 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A34D812D8B16; Sat, 9 Oct 2021 06:18:48 +0000 (UTC) (envelope-from pstef@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HRFHr3yXcz3j7N; Sat, 9 Oct 2021 06:18:48 +0000 (UTC) (envelope-from pstef@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1633760328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vkj3JdQSToPc2w2Cj5wKBNAUEpOwHAhGUyzmAUj44wo=; b=CA6TgVO822bQySsLvjpleNOcWeFHd2+S3zRjwHfBrfaR/8iPs6X9q52CoJnP9YohWb7F9F FtYnaMo8L2t60vLBD/TcSU2XtTx/UQ5M9kurRPFI7o9s0CtIszi/AnFIPsbYH+QyRdYqdv jrRBf0VRWONuwXT6bgdw+oRqb4a4Cd769QeOlWdN0MJ4uUdzhhmvW+qS4wYuqVCToIYao7 z3jbnSiRsra+jnhQWAYfJbvtE4/4ll22HF0ko4quGHTfKGy4t74MHSTHjMyrQvMN+doZRf u5L9F3xgA9IF80gaR/lIsDY+JyyHYCHaav6c6gAFCHKdNMjvLdP+LwO2BHA51w== Received: by freefall.freebsd.org (Postfix, from userid 1403) id 65320D18; Sat, 9 Oct 2021 06:18:48 +0000 (UTC) Date: Sat, 9 Oct 2021 06:18:48 +0000 From: "Piotr P. Stefaniak" To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: bf8f6ffcb66a - main - Mention kern.timecounter.alloweddeviation in nanosleep.1 Message-ID: References: <202110081509.198F94HG022514@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1633760328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vkj3JdQSToPc2w2Cj5wKBNAUEpOwHAhGUyzmAUj44wo=; b=T0TSWo0Embq72zyPH3z6Z+SSrf9nKTPmsB594Q8GX+qkf9bRNf5QDYCCYfHgY5wrKvMtkD bbXqdBhfS53lLVwovVzuM/kCVNQJbJWcBqnFgZEUTPUiJUhSFUTA0zziE96yWoSXlnGWxS sC3+L4tKfeTPOJVzkJ+yNAk6GUrWnY4XT+r24hNakSxMHCIDIeYwfj9T0Z+cHNMAyn4r9u S89uOZwsXkk4LgdJ8GVbR6ph8/ADncSes49AomGUjjVSnLCZpLmSwxEP88EgKH/pC80nte PqksyyRPIJiRspcjtXviaPePWcZNGUibMSN7cQ4/U4lpxG/Yvq9pyk4iGZeWYw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1633760328; a=rsa-sha256; cv=none; b=WLeDHdasFZCii2ANM55TBxjMLPkgj9NlB1i7OL1BDBIVypjh5AdGHGJ73Jm0+qcP/vztG3 K9wQX47hK9kSIOv9Gehdj4O8zIS0ecEpkr2yqtRdlCaliBvolX0ABEBQy3CCo6AnqpdopL ewv2iBmFfSmVIabVQLJPaSF5Ax7SYS1JifNfNcahmSC0HPhODqb30Uwj8nx8hQ82Mw6OKO Q0wY232+5N0G2zG9zro60PqTJqHaQElX6iftMHpJqaKuwozTN6MYLfguIl+el5D57M0rn/ o4sj/m4WuTLyACsPhlMmJzp7EspQLhVJSWT1NqGKdhjcgindg8gGF91Czfc35g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 2021-10-09 08:53:08, Konstantin Belousov wrote: >On Fri, Oct 08, 2021 at 03:09:04PM +0000, Piotr Pawel Stefaniak wrote: >> @@ -93,6 +93,8 @@ returns immediately and the calling thread is not suspended. >> .Pp >> The suspension time may be longer than requested due to the >> scheduling of other activity by the system. >> +It is also subject to the allowed time interval deviation >> +specified by the sysctl kern.timecounter.alloweddeviation. >This should be like >.Xr sysctl 3 >.Dv kern.timecounter.alloweddeviation @@ -94,7 +94,9 @@ returns immediately and the calling thread is not suspended. The suspension time may be longer than requested due to the scheduling of other activity by the system. It is also subject to the allowed time interval deviation -specified by the sysctl kern.timecounter.alloweddeviation. +specified by the +.Xr sysctl 3 +.Dv kern.timecounter.alloweddeviation . An unmasked signal will terminate the sleep early, regardless of the .Dv SA_RESTART value on the interrupting signal. >And then, it is missing a description what exactly is allowed by deviation, >for instance, what units this sysctl is? That would be redundant with sysctl -d. The point of this change is that now the user is much more likely to know of the sysctl and can look it up and read all about it. The bug may be that there isn't much documentation to be read about it, only sysctl -d and kern_tc.c. The only thing I worry that may be missing from this change is this reference in any other manual pages that might need it as much as nanosleep.