From owner-svn-src-head@FreeBSD.ORG  Mon Jul 21 09:07:24 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from ptrcrt.ch (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EFDA359E;
 Mon, 21 Jul 2014 09:07:22 +0000 (UTC)
Date: Mon, 21 Jul 2014 11:07:18 +0200
From: Pietro Cerutti <gahr@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r268494 - in head: lib/libsbuf sys/kern sys/sys
Message-ID: <20140721090718.GC51328@ptrcrt.ch>
Reply-To: gahr@FreeBSD.org
References: <201407101308.s6AD8pbR080041@svn.freebsd.org>
 <f964663ce71f8554198c1a8fc2ccda60@shatow.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="LyciRD1jyfeSSjG0"
Content-Disposition: inline
In-Reply-To: <f964663ce71f8554198c1a8fc2ccda60@shatow.net>
X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8  6D49 ADD0 D38E A192 089E";
 id="0xA192089E";
 get=<hkp://pgp.mit.edu/pks/lookup?search=0xADD0D38EA192089E&op=get>;
 get=<https://keyserver.pgp.com/vkd/DownloadKey.event?keyid=0xADD0D38EA192089E>;
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, owner-src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jul 2014 09:07:24 -0000


--LyciRD1jyfeSSjG0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2014-Jul-18, 18:47, Bryan Drewery wrote:
> On 2014-07-10 08:08, Pietro Cerutti wrote:
> > Author: gahr (ports committer)
> > Date: Thu Jul 10 13:08:51 2014
> > New Revision: 268494
> > URL: http://svnweb.freebsd.org/changeset/base/268494
> >=20
> > Log:
> >   Implement Short/Small String Optimization in SBUF(9) and change=20
> > lengths and
> >   positions in the API from ssize_t and int to size_t.
> >=20
> >   CR:		D388
> >   Approved by:	des, bapt
> >=20
> > Modified:
> >   head/lib/libsbuf/Makefile
> >   head/sys/kern/subr_sbuf.c
> >   head/sys/sys/sbuf.h
> >=20
> > Modified: head/lib/libsbuf/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/lib/libsbuf/Makefile	Thu Jul 10 13:04:52 2014	(r268493)
> > +++ head/lib/libsbuf/Makefile	Thu Jul 10 13:08:51 2014	(r268494)
> > @@ -4,7 +4,7 @@ LIB=3D		sbuf
> >  SHLIBDIR?=3D 	/lib
> >  SRCS=3D		subr_sbuf.c
> >=20
> > -SHLIB_MAJOR	=3D 6
> > +SHLIB_MAJOR	=3D 7
> >=20
> >  SYMBOL_MAPS=3D    ${.CURDIR}/Symbol.map
> >  VERSION_DEF=3D	${.CURDIR}/Version.def
> >=20
>=20
> We have symbol versioning in libsbuf. Shouldn't need to bump the=20
> version. Just need to add a compat function for everything. It would be=
=20
> a lot of work, but bumping for ssize_t->size_t seems gratuitous to me.

The bump was due mainly to the addition of the s_static_buf field to the
sbuf struct.

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--LyciRD1jyfeSSjG0
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJTzNhGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB
REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgie0L8P/1ZDdbBcqq5R2LZB2aN5RWxU
77tpZeTzV576p1pkvzvkt+OUlVvBpxrjOA7o+PEmw0w1BzIIS4Mz2OUqNuci/M3K
EU/ar1yyQghEknXiS8MW4KfpPJqSbInfnnXv+/i6YTjSVN4SH7ZVMZoucmfub9zI
iZSn29ZGhXMgUBvEDyH09uGsyAvOcVcGX0UuZKHXV3VNiYOwz1WvWYhbls9Zky3b
2nG0CM5v+JURJfC3xE13EHkq6gkDSWFbd3SK0psdQOKfRVhTs6n7cKIRdaghIKFo
KK+CuVQJKI16FRDex3bh4zZgpAu/iTvRpxBQsx/IL9WUEIL7rChDgvFQ+ok9aDCB
9iteikJqK40NQyM/LgfYdPgFENYKgti3+sxbwBOvRvu183FQrTdPhC/1uiE07zrp
AUAG/vUAWCR/5l4qYjrjIfgz+LkCap7d2WdddLQEiY39LwqVHipe1S5afhg3kFoh
cDmC4KYX9GGvzuPpqb4jroyDD0zoeFLfcspkTXfr03kRN27E82IQrLFbVq/6IOHj
3qzasU0B0c4kHHJtrTEJYCSmIlb/GcK0QRsPQ/VIJhe6ttGnov9KLrnmdeunvfM6
v4aaKFOUhxYGuzn5C5RPcGuXXAHa7NL/hg619HGKWMk4W1P7Wf0AhBJyp9KWtAgm
xb6WQspUNRbkn6NcmZ2Y
=DXz8
-----END PGP SIGNATURE-----

--LyciRD1jyfeSSjG0--