From owner-freebsd-net@FreeBSD.ORG  Sun Dec 31 19:09:53 2006
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7E6A416A415
	for <freebsd-net@freebsd.org>; Sun, 31 Dec 2006 19:09:53 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outF.internet-mail-service.net (outF.internet-mail-service.net
	[216.240.47.229])
	by mx1.freebsd.org (Postfix) with ESMTP id 5DA3713C43E
	for <freebsd-net@freebsd.org>; Sun, 31 Dec 2006 19:09:53 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from shell.idiom.com (HELO idiom.com) (216.240.47.20)
	by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP;
	Sun, 31 Dec 2006 10:52:29 -0800
Received: from [192.168.2.4] (home.elischer.org [216.240.48.38])
	by idiom.com (8.12.11/8.12.11) with ESMTP id kBVJ9nXW082192;
	Sun, 31 Dec 2006 11:09:50 -0800 (PST)
	(envelope-from julian@elischer.org)
Message-ID: <45980AFD.6010902@elischer.org>
Date: Sun, 31 Dec 2006 11:09:49 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207)
MIME-Version: 1.0
To: Yar Tikhiy <yar@comp.chem.msu.su>
References: <457DCD47.5090004@elischer.org>
	<200612120045.41425.max@love2party.net>
	<4583119B.20608@elischer.org>
	<200612160446.02644.max@love2party.net>
	<4584CE0C.3020307@elischer.org> <458C426A.9060604@elischer.org>
	<20061224093951.GD49045@comp.chem.msu.su>
	<459032EA.1030601@elischer.org>
	<20061226061610.GD81280@comp.chem.msu.su>
	<4591A2D3.50708@elischer.org>
	<20061230173053.GB94532@comp.chem.msu.su>
In-Reply-To: <20061230173053.GB94532@comp.chem.msu.su>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Max Laier <max@love2party.net>, Andre Oppermann <andre@freebsd.org>,
	freebsd-net@freebsd.org
Subject: Re: [was] addition to ipfw (read vlans from bridge)..
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Dec 2006 19:09:53 -0000

Yar Tikhiy wrote:

> 
> However, I have one question regarding "etype", please see below.
> 
[...]

>>  
>> +	/*
>> +	 * if we have an ether header,
>> +	 */
>> +	if (args->eh)
>> +		etype = (ntohs(args->eh->ether_type)) == ETHERTYPE_VLAN;
> 
> And here we assign a boolean value to etype.  Is it intended?
> Looks like a error to me.  Apparently it should read:
> 
> 		etype = ntohs(args->eh->ether_type);

exactly.. cut-n-paste-o

> 
> But some processing of the (etype == ETHERTYPE_VLAN) case may be
> missing here.

ipfw should not really be interested in the VLAN case with these changes.