From owner-cvs-lib Sun Jun 29 04:02:18 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id EAA28322 for cvs-lib-outgoing; Sun, 29 Jun 1997 04:02:18 -0700 (PDT) Received: from genesis.atrad.adelaide.edu.au (genesis.atrad.adelaide.edu.au [129.127.96.120]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id EAA28302; Sun, 29 Jun 1997 04:02:11 -0700 (PDT) Received: (from msmith@localhost) by genesis.atrad.adelaide.edu.au (8.8.5/8.7.3) id UAA19302; Sun, 29 Jun 1997 20:32:02 +0930 (CST) From: Michael Smith Message-Id: <199706291102.UAA19302@genesis.atrad.adelaide.edu.au> Subject: Re: cvs commit: src/lib/libc/gen stringlist.c In-Reply-To: <199706291050.UAA31042@godzilla.zeta.org.au> from Bruce Evans at "Jun 29, 97 08:50:38 pm" To: bde@zeta.org.au (Bruce Evans) Date: Sun, 29 Jun 1997 20:32:01 +0930 (CST) Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, jkh@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL28 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans stands accused of saying: > > Modified files: > > lib/libc/gen stringlist.c > > Log: > > _err() -> err(). > > Error! Library functions should not call functions in the user namespace. > stringlist.c depended on NetBSD's implementantion of `_err' as the core > function with the library `err' a weak alias for `err'. Eep. > `err' was not misused by the library before, but ISTR that other [v]err* > or [v]warn* functions are misused. Should we then adopt the NetBSD convention and make the err family safely accessible to other library functions? > Bruce -- ]] Mike Smith, Software Engineer msmith@gsoft.com.au [[ ]] Genesis Software genesis@gsoft.com.au [[ ]] High-speed data acquisition and (GSM mobile) 0411-222-496 [[ ]] realtime instrument control. (ph) +61-8-8267-3493 [[ ]] Unix hardware collector. "Where are your PEZ?" The Tick [[