Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 13 Dec 2023 07:37:39 -0500
From:      Adam Weinberger <adamw@adamw.org>
To:        Mathieu Arnold <mat@freebsd.org>
Cc:        Gerald Pfeifer <gerald@pfeifer.com>, Larry Rosenman <ler@freebsd.org>,  Ashish SHUKLA <ashish@freebsd.org>, ports-committers@freebsd.org,  dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 8d096cbc7af5 - main - sysutils/lsof: add a build depends on bash for the timebeing.
Message-ID:  <CAP7rwcjXhUGT_MiSi6gseMnLGXmn39vUmyA9r0GGrtLFaz7_cQ@mail.gmail.com>
In-Reply-To: <magfc3arlgw6cnqa4bgl73ho344bvrnthionsr4gaig6kab5wy@mo7mzrlc4blx>
References:  <202312050108.3B518qwD065426@gitrepo.freebsd.org> <653e5bc3811b06d371517936f02cf0c2@FreeBSD.org> <1e93ed1a910819a38a332a580b4746d0@FreeBSD.org> <526e9cf0-55cf-afac-b8b5-5005e63cc6ae@pfeifer.com> <CAP7rwcieVLpb9Z4ENHBxkRb88XkToj7TWZccKhPq=q-L_JWyyw@mail.gmail.com> <magfc3arlgw6cnqa4bgl73ho344bvrnthionsr4gaig6kab5wy@mo7mzrlc4blx>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
On Wed, Dec 13, 2023 at 7:20 AM Mathieu Arnold <mat@freebsd.org> wrote:

> On Wed, Dec 13, 2023 at 06:32:44AM -0500, Adam Weinberger wrote:
> > On Wed, Dec 13, 2023 at 12:26 AM Gerald Pfeifer <gerald@pfeifer.com>
> wrote:
> >
> > > On Mon, 4 Dec 2023, Larry Rosenman wrote:
> > > >>> +BUILD_DEPENDS=             /usr/local/bin/bash:shells/bash
> > > >> s,/usr/local,${LOCALBASE},
> > > > I'm out of practice :(
> > >
> > > No worries, just note we have tools to support us.
> > >
> > > I gave this a try and got the following from portlint:
> > >
> > >   % portlint -C
> > >   WARN: Makefile: possible use of absolute pathname
> > > "/usr/local/bin/bash:...".
> > >
> >
> > Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. This
> > would work fine too (and is the more common invocation):
> > BUILD_DEPENDS=  bash:shells/bash
>
> They are semantically different.
>
> bash:shells/bash means I need a bash executable, like, for running shell
> scripts.
>
> LOCAL/bin/bash:shells/bash means I need the LOCAL/bin/bash file, it may
> not be for execution. It is more usually used for a header, I do not see
> why one would need bash but not for running it.
>
> --
> Mathieu Arnold
>

That's a good point, and my message definitely glossed over that.

  foo:net/foo  ==  ${LOCALBASE}/bin/foo:net/foo    (as long as foo is not
in base)

  ${LOCALBASE}/share/foo/foo.h:net/foo  for non-executables

# Adam


-- 
Adam Weinberger
adamw@adamw.org
https://www.adamw.org

[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Dec 13, 2023 at 7:20 AM Mathieu Arnold &lt;<a href="mailto:mat@freebsd.org">mat@freebsd.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Dec 13, 2023 at 06:32:44AM -0500, Adam Weinberger wrote:<br>
&gt; On Wed, Dec 13, 2023 at 12:26 AM Gerald Pfeifer &lt;<a href="mailto:gerald@pfeifer.com" target="_blank">gerald@pfeifer.com</a>&gt; wrote:<br>
&gt; <br>
&gt; &gt; On Mon, 4 Dec 2023, Larry Rosenman wrote:<br>
&gt; &gt; &gt;&gt;&gt; +BUILD_DEPENDS=             /usr/local/bin/bash:shells/bash<br>
&gt; &gt; &gt;&gt; s,/usr/local,${LOCALBASE},<br>
&gt; &gt; &gt; I&#39;m out of practice :(<br>
&gt; &gt;<br>
&gt; &gt; No worries, just note we have tools to support us.<br>
&gt; &gt;<br>
&gt; &gt; I gave this a try and got the following from portlint:<br>
&gt; &gt;<br>
&gt; &gt;   % portlint -C<br>
&gt; &gt;   WARN: Makefile: possible use of absolute pathname<br>
&gt; &gt; &quot;/usr/local/bin/bash:...&quot;.<br>
&gt; &gt;<br>
&gt; <br>
&gt; Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. This<br>
&gt; would work fine too (and is the more common invocation):<br>
&gt; BUILD_DEPENDS=  bash:shells/bash<br>
<br>
They are semantically different.<br>
<br>
bash:shells/bash means I need a bash executable, like, for running shell<br>
scripts.<br>
<br>
LOCAL/bin/bash:shells/bash means I need the LOCAL/bin/bash file, it may<br>
not be for execution. It is more usually used for a header, I do not see<br>
why one would need bash but not for running it.<br>
<br>
-- <br>
Mathieu Arnold<br>
</blockquote></div><div><br></div><div><div style="font-family:arial,sans-serif" class="gmail_default">That&#39;s a good point, and my message definitely glossed over that.</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">  foo:net/foo  ==  ${LOCALBASE}/bin/foo:net/foo    (as long as foo is not in base)</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">  ${LOCALBASE}/share/foo/foo.h:net/foo  for non-executables<br></div></div><div><br></div><div><div style="font-family:arial,sans-serif" class="gmail_default"># Adam<br></div><br></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Adam Weinberger</div><div><a href="mailto:adamw@adamw.org" target="_blank">adamw@adamw.org</a></div><div><a href="https://www.adamw.org" target="_blank">https://www.adamw.org</a></div></div></div></div></div></div>;
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcjXhUGT_MiSi6gseMnLGXmn39vUmyA9r0GGrtLFaz7_cQ>