From owner-freebsd-ports@FreeBSD.ORG  Wed Jan 26 01:36:51 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 49AC216A4CE
	for <ports@FreeBSD.org>; Wed, 26 Jan 2005 01:36:51 +0000 (GMT)
Received: from tenebras.com (graystone.tenebras.com [216.27.179.139])
	by mx1.FreeBSD.org (Postfix) with SMTP id CE38043D2F
	for <ports@FreeBSD.org>; Wed, 26 Jan 2005 01:36:50 +0000 (GMT)
	(envelope-from kudzu@tenebras.com)
Received: (qmail 71209 invoked from network); 26 Jan 2005 01:36:50 -0000
Received: from grayair.tenebras.com (HELO ?127.0.0.1?) (192.168.188.166)
  by hospital.tenebras.com with SMTP; 26 Jan 2005 01:36:50 -0000
Message-ID: <41F6F431.6060005@tenebras.com>
Date: Tue, 25 Jan 2005 17:36:49 -0800
From: Michael Sierchio <kudzu@tenebras.com>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: lioux@FreeBSD.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: ports@FreeBSD.org
Subject: FreeBSD Port: qmail-1.03_3
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2005 01:36:51 -0000


You have added a patch which is totally unneccesary, and I
suggest that it be removed:

in your patch-qmail-local....

-     while ((k > i) && (cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t'))
+     while ((k > i) && ((cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t')))

This is totally bogus, the original code is correct.  Please do not
make changes to contributed code simply because it makes it easier
for you to understand.  There is no semantic difference between the
two, ERGO the patch should not exist.  Please remove it.

Shall I file a PR?


- Michael