From nobody Tue Apr 21 11:32:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g0KwN0QhKz6bfJL for ; Tue, 21 Apr 2026 11:32:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g0KwM6BsFz3XcV for ; Tue, 21 Apr 2026 11:32:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776771171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tOLztG698otLJ8103bhDqrm6E3TUPgiijWEOD5byXtA=; b=rxE+Com6Mrk4PutQIUWoDEvc2sYHcL3Bn256NRBT2Zu66NJx+ooXzYXHxFtFOpkV7U3ttU LPzkYyinz1kCo87AQr5uyDa5qEez3ZP6EID+glcjkscU4MxpqNqlHthqN0a2nPt/tUXxJf 3RrPtv4fEHI92Dofjn7vxSn2vUHubDpvBS0ZIyI6icMKkcz74kzS6OrzYpJZSA/RTwpFfJ wSunhEzNW3TWtycsyvQn6abVnd0ojRvMdtBz16dS+Z+8SVGt1HV301eSj+yAwsu6zyNDr8 1gEXOPXKiR0Wlf+RxzxngIXDtK6hqbNlHEKEI1mv90LOtCcRaRpZmjySzHFk1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776771171; a=rsa-sha256; cv=none; b=lGG+p/rUlJMBHHuF+C9Re9GRGX3WHGFhlaVwfzUC4Oq2y+RxE8nFiheKCEkmoBQY7Ff2sR PinntHvHbsh76I1lRJhT8SkULVJfsKjeEgLamKqfD/Qp2AKdrCSR89+HtwQYKm/w/pipX1 MvjY8PXDlhYygVDxvMShJ/KVUACtt78lzBHGmlna1Qz2ZGDxNEIq8iTDQaW8eOoXFu6i0Y LGf+oJg3AXfzbymcoASJSl7Xd6+sCIJxjJglxMhDEWxmB8mK+26Iir442fBqOmqDit0Gr0 gHO5lAra7EYaC2JzoLSzU7bBH+uREYO8LaS0qS22PentZMcCran37gDvugNSjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776771171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tOLztG698otLJ8103bhDqrm6E3TUPgiijWEOD5byXtA=; b=k3X9u7pXx6tC7OMvEcJa9u5/h2aSMPxSblUwI//JPAP3MQyoI87Be5Dy8Lr2nKScbxyh/I cT1f7qmH00NFsSbhALvy3n4w+9j7CRroDmpxPIUNXMJsSa6v5b93QaMTLXN0Ymol5xO1WL Q4xZzEH/YEBzDtiKUQLh52G1WaV6YzdRc4/TO+ReT6ueOJ6ZVlPCwgIMP5n5PYr81YH0fV wPsFEU0OtvhCyMICPlxJKuIPDvfbqFd29G8K5ZEXm52r9uZPB5/A8dTRU1HP28D5GTk3re q8b7BQwKyyNQcRMgnjzOfpzTyYgVbbTf0vE5KmwSqqiEZ8gzbgLZQz+hd/HY7g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g0KwM5lTFzjLk for ; Tue, 21 Apr 2026 11:32:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 42e19 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 21 Apr 2026 11:32:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: d5ca00f2d874 - main - pf: do not allow flags to be changed with securelevel set List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d5ca00f2d8743f0885c17f50c8c011cae285fbdb Auto-Submitted: auto-generated Date: Tue, 21 Apr 2026 11:32:51 +0000 Message-Id: <69e76063.42e19.76af3a5f@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=d5ca00f2d8743f0885c17f50c8c011cae285fbdb commit d5ca00f2d8743f0885c17f50c8c011cae285fbdb Author: Kristof Provost AuthorDate: 2026-04-13 13:48:39 +0000 Commit: Kristof Provost CommitDate: 2026-04-21 09:51:28 +0000 pf: do not allow flags to be changed with securelevel set With securelevel set (for pf that means >= 3) we're expected to reject rule changes. However, we allowed interface flags to be changed, which would allow 'set skip on X' to be changed. Remove DIOCSETIFFLAG and DIOCCLRIFFLAG from the securelevel whitelist. MFC after: 1 week Reported by: cyberkittens Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf_ioctl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c index 8b2ff108d9cb..586d896d0e2d 100644 --- a/sys/netpfil/pf/pf_ioctl.c +++ b/sys/netpfil/pf/pf_ioctl.c @@ -3899,8 +3899,6 @@ pfioctl(struct cdev *dev, u_long cmd, caddr_t addr, int flags, struct thread *td case DIOCIGETIFACES: case DIOCGIFSPEEDV0: case DIOCGIFSPEEDV1: - case DIOCSETIFFLAG: - case DIOCCLRIFFLAG: case DIOCGETETHRULES: case DIOCGETETHRULE: case DIOCGETETHRULESETS: