From owner-svn-src-projects@freebsd.org Tue Feb 26 18:58:25 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0F061522F93 for ; Tue, 26 Feb 2019 18:58:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 72D946DFE4; Tue, 26 Feb 2019 18:58:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f194.google.com with SMTP id v2so5470739ith.3; Tue, 26 Feb 2019 10:58:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=jQZRG41Lur71DBZdBfqLoieN5/35kbP5lL7bYe97cd0=; b=R5pImBEiY20IFzCCBSV1FFc71gASf7ajJvFwlMPKG/A+EUZQl+0mQjMS4Glj14Lbcs 7sXcpdrxJaRSeB+g53gcqiT0dX53NfgBMj1yQqmf4+o0/YKqs0CzLRkmrDUwAasF+5LS SCtte07MYsoe0C5KuRPKezQjSBcbEWb/Ndl0y7p4BkhTQQbpYsirxl4w0J+OoeKsU3m9 LGbF9HLjMKaWWG3v+y/RfbWEYvuDK82sY/eRw14GRFqIXT0vcNBEO19rJKgisYtYBopi 3bDHp6V6rMpAzuZWGjneLsyLSAKsq6EqgvP/qzQaQHm5EFOzyI1n9twpD7X+OK1iSYmv NCDA== X-Gm-Message-State: APjAAAXxYf9aBhM+E38QuiRQqsAWwC4Og0QYw5LP/ezp1++fzmNKpGoj Zmm5YiR9zLRhWiRoW+RmaWh/C7yw X-Google-Smtp-Source: AHgI3IYJhveIlz8WqucWlnCb5ehnZ3WwIgcteTTG3tIVoEGS1jcY8QJvGbH58x5+1y4nG+pRYnik8w== X-Received: by 2002:a24:d55:: with SMTP id 82mr1966428itx.21.1551207497448; Tue, 26 Feb 2019 10:58:17 -0800 (PST) Received: from mail-it1-f178.google.com (mail-it1-f178.google.com. [209.85.166.178]) by smtp.gmail.com with ESMTPSA id l19sm5204501iob.46.2019.02.26.10.58.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 10:58:17 -0800 (PST) Received: by mail-it1-f178.google.com with SMTP id z124so5841443itc.2; Tue, 26 Feb 2019 10:58:17 -0800 (PST) X-Received: by 2002:a24:bdcc:: with SMTP id x195mr3392144ite.149.1551207497113; Tue, 26 Feb 2019 10:58:17 -0800 (PST) MIME-Version: 1.0 References: <201902260328.x1Q3SEbK009132@repo.freebsd.org> <306af793-6776-cf1b-fc19-f0a66e59be84@FreeBSD.org> In-Reply-To: <306af793-6776-cf1b-fc19-f0a66e59be84@FreeBSD.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Tue, 26 Feb 2019 10:58:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r344558 - in projects/fuse2: . sbin/ifconfig To: Pedro Giffuni Cc: Alan Somers , src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 72D946DFE4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 18:58:25 -0000 Hi Pedro, On Tue, Feb 26, 2019 at 10:12 AM Pedro Giffuni wrote: > Yes they keep that file under a BSD license, and order is important. I > think we actually have to stop around 7.13 unless we are willing to > support the linux splice call. I don't think splice is necessary. libfuse today already handles kernels that do not support SPLICE capability by emulating in userspace. It doesn't even request the capability of the kernel unless all of the following are true: 1. Userspace defines a splice() function. 2. Kernel advertises version 7.14+ ( https://github.com/libfuse/libfuse/blob/0c73b8389aaea156e7544d984be95515b9743033/lib/fuse_lowlevel.c#L1910 ) And it doesn't use the splice syscall on fuse fds unless the kernel additionally advertises the capability. We simply won't advertise the capability, and since we don't have the function at all, libfuse built on FreeBSD won't even compile the code wrapped in HAVE_SPLICE. I agree there will probably be some stumbling blocks, but I don't think splice is going to be one of them. And I think libfuse upstream is very receptive to any compatibility shims we might need to coordinate with them if it helps get us beyond 7.8 :-). Best, Conrad