From owner-cvs-src-old@FreeBSD.ORG Wed Feb 18 19:59:37 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB0A31065785 for ; Wed, 18 Feb 2009 19:59:37 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C8D748FC27 for ; Wed, 18 Feb 2009 19:59:37 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n1IJxbl1006530 for ; Wed, 18 Feb 2009 19:59:37 GMT (envelope-from imp@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n1IJxbBA006529 for cvs-src-old@freebsd.org; Wed, 18 Feb 2009 19:59:37 GMT (envelope-from imp@repoman.freebsd.org) Message-Id: <200902181959.n1IJxbBA006529@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to imp@repoman.freebsd.org using -f From: Warner Losh Date: Wed, 18 Feb 2009 19:59:27 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/bsnmp/snmp_mibII mibII.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2009 19:59:38 -0000 imp 2009-02-18 19:59:27 UTC FreeBSD src repository Modified files: contrib/bsnmp/snmp_mibII mibII.c Log: SVN rev 188760 on 2009-02-18 19:59:27Z by imp Add an extra (void *) cast. The struct if_msghdr has an 8 byte alignment requirement, while rt_msghdr has a 4 byte alignment requirement. The root cause is that if_msghdr has an struct if_data which has an 8-byte alignment requirement due to a time_t that's embedded in it. On MIPS, time_t is a 64-bit number, so must be 64-bit aligned. Since we don't access ifm_data.ifi_epoch, a simple cast is all that's necessary here. It is likely the case that ifi_epoch should *NOT* be a time_t because it is an uptime (time delta) an not an absolute time since 1970. u_long is likely sufficient there since that gives an uptime of 136 years will suffice for the foreseeable future. Revision Changes Path 1.3 +1 -1 src/contrib/bsnmp/snmp_mibII/mibII.c