From owner-freebsd-net@FreeBSD.ORG  Thu Mar 22 19:32:06 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 858311065673
	for <freebsd-net@freebsd.org>; Thu, 22 Mar 2012 19:32:06 +0000 (UTC)
	(envelope-from bschmidt@techwires.net)
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
	[74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 09EB48FC19
	for <freebsd-net@freebsd.org>; Thu, 22 Mar 2012 19:32:05 +0000 (UTC)
Received: by wern13 with SMTP id n13so2849235wer.13
	for <freebsd-net@freebsd.org>; Thu, 22 Mar 2012 12:32:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to
	:mime-version:content-type:content-transfer-encoding:message-id
	:x-gm-message-state;
	bh=g4cpy7nli1W+YdWHhzYGyPRbIg54XH5RxQI0Xpr7Cy8=;
	b=JZjGqOaPxCgKzonozQQVOEtB3pTy0c06EGR8FHlPbgdcm/a/ovUwJ7BvibfLHH5h3f
	XMk05l7hvdFmXrmyBOWzsuIpJ9R43q76G/bqU8xgFEX+poMcx4UgVbauXtDHChz2SMF0
	VD/S4J1BUtK6mUYfeXsz5Jj1K/rI/wth+vh0JgzG2i+JmB1vdS+JnG9SsGzvSoFiosZC
	G7hmkpCuNvTExcykb1WbHQ1WqBhuTk05e9twk27p76LR3e0XRPk6lbNKWjVkET/wCh+u
	aW6Nh8ktuIdTxJzCcNQSSrYvqys0v+Nj7M5c2aucwDMXJbOf9cHKeYMoWNafKCoNo2DG
	Q7Og==
Received: by 10.216.138.38 with SMTP id z38mr5333023wei.63.1332444724792;
	Thu, 22 Mar 2012 12:32:04 -0700 (PDT)
Received: from amy.lab.techwires.net (dslb-088-065-222-166.pools.arcor-ip.net.
	[88.65.222.166])
	by mx.google.com with ESMTPS id fn2sm12553923wib.0.2012.03.22.12.32.01
	(version=SSLv3 cipher=OTHER); Thu, 22 Mar 2012 12:32:04 -0700 (PDT)
Sender: Bernhard Schmidt <bschmidt@techwires.net>
From: Bernhard Schmidt <bschmidt@freebsd.org>
To: Adrian Chadd <adrian@freebsd.org>
Date: Thu, 22 Mar 2012 20:32:20 +0100
User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; )
References: <CA+sBSoJaxxRRsUqmpN6k8q6M_SZ_605ip6auN44k5BQ7a_XOtQ@mail.gmail.com>
	<CAJ-VmonJ5w-GpnkXqorqFJ+DcZqoR9kdoPkt9w9A-sXuQccodA@mail.gmail.com>
	<CAJ-VmonRmrJ6uQchbY6m=gv8t0jmLkOVbtqqXdV7_frEczOXkQ@mail.gmail.com>
In-Reply-To: <CAJ-VmonRmrJ6uQchbY6m=gv8t0jmLkOVbtqqXdV7_frEczOXkQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201203222032.20699.bschmidt@freebsd.org>
X-Gm-Message-State: ALoCoQk1JmqT6K5Kc8SUIaUD0MaHGqmBt8X7GjDcoGDsLp2ZsBcyzCCByDvsT4gyOk/QCz9ADvlv
Cc: Monthadar Al Jaberi <monthadar@gmail.com>, freebsd-net@freebsd.org
Subject: Re: ifconfig meshforward command bug
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Mar 2012 19:32:06 -0000

On Thursday 22 March 2012 19:56:57 Adrian Chadd wrote:
> On 22 March 2012 11:56, Adrian Chadd <adrian@freebsd.org> wrote:
> > On 22 March 2012 11:28, Bernhard Schmidt <bschmidt@freebsd.org> wrote:
> >
> >> Seems about right, those declared with DEF_CMD() should use d.
> >
> > Shall I commit this?
> 
> .. a lot of these mesh functions use DECL_CMD_FUNC(), should they all
> be using d?

Take a look at the top of the file, just the once with DEF_CMD() where
the parameter is included, those should use d.

-- 
Bernhard