Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Apr 2015 15:07:22 +0200
From:      Emanuel Haupt <ehaupt@FreeBSD.org>
To:        Emanuel Haupt <ehaupt@FreeBSD.org>
Cc:        Renato Botelho <garga@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, adamw@FreeBSD.org
Subject:   Re: svn commit: r384682 - in head/security/keychain: . files
Message-ID:  <20150425150722.568d8d52eb71eb774c29a70a@FreeBSD.org>
In-Reply-To: <20150425114020.4743fe0a5771addb3db585b9@FreeBSD.org>
References:  <201504242009.t3OK9vtp090926@svn.freebsd.org> <20150425114020.4743fe0a5771addb3db585b9@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Emanuel Haupt <ehaupt@FreeBSD.org> wrote:
> Renato Botelho <garga@FreeBSD.org> wrote:
> > Author: garga
> > Date: Fri Apr 24 20:09:57 2015
> > New Revision: 384682
> > URL: https://svnweb.freebsd.org/changeset/ports/384682
> > 
> > Log:
> >   Update to 2.8.0
> >   
> >   PR:		199300 (based on)
> >   Submitted by:	adamw@
> 
> After the update I get:
> 
> $ keychain 
> /usr/local/bin/keychain: shopt: not found
> /usr/local/bin/keychain: 848: Syntax error: "(" unexpected (expecting
> ")")
> 

Looking at it a bit closer shows that the new version sets:

shopt -s extglob

but uses:

#!/bin/sh

This is probably no problem on most Linuxes that simply link /bin/sh
to /bin/bash but it won't work on FreeBSD.

The way I see it keychain needs to either start using

#!/usr/local/bin/bash

as shebang or the expressions that require extglob need to be
made FreeBSD /bin/sh compatible. The first one is IMHO better
for future maintainability.

Emanuel



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150425150722.568d8d52eb71eb774c29a70a>