Date: Sat, 30 Apr 2016 18:20:29 +0200 From: John Marino <freebsd.contact@marino.st> To: gahr@FreeBSD.org, marino@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r413727 - in head: Mk/Uses cad/irsim cad/magic cad/netgen cad/netgen/files cad/xcircuit lang/expect lang/itcl lang/itcl4 lang/itcl4/files lang/nx www/mod_rivet www/tclhttpd www/tdom www... Message-ID: <5724DB4D.6020009@marino.st> In-Reply-To: <20160430140629.GA55848@ptrcrt.ch> References: <201604211133.u3LBXH1a051587@repo.freebsd.org> <572489C8.8000803@marino.st> <20160430140629.GA55848@ptrcrt.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/30/2016 4:06 PM, Pietro Cerutti wrote: > On 2016-Apr-30, 12:32, John Marino wrote: >> On 4/21/2016 1:33 PM, Pietro Cerutti wrote: >>> Author: gahr >>> Date: Thu Apr 21 11:33:16 2016 >>> New Revision: 413727 >>> URL: https://svnweb.freebsd.org/changeset/ports/413727 >>> >>> Log: >>> Support Tk in USES=tk:tea. Convert more ports + minor fixes and modernization. > > [snip] > >> [snip] >> >>> >>> Modified: head/lang/expect/Makefile >>> ============================================================================== >>> --- head/lang/expect/Makefile Thu Apr 21 11:18:13 2016 (r413726) >>> +++ head/lang/expect/Makefile Thu Apr 21 11:33:16 2016 (r413727) >>> @@ -14,25 +14,16 @@ LIBEXPECT_VER= ${PORTVERSION:S/.//g} >>> >>> WRKSRC= ${WRKDIR}/${DISTNAME} >>> >>> -USES= tcl autoreconf >>> +USES= tcl:tea autoreconf >>> USE_LDCONFIG= yes >>> -GNU_CONFIGURE= yes >>> -CONFIGURE_ARGS= --enable-shared \ >>> - --exec-prefix=${PREFIX} \ >>> - --datadir=${DATADIR} \ >>> - --with-tclconfig=${TCL_LIBDIR} \ >>> - --with-tclinclude=${TCL_INCLUDEDIR} >>> -CONFIGURE_ENV= ac_cv_sys_long_file_names=yes >>> +CONFIGURE_ARGS= --datadir=${DATADIR} >>> PLIST_SUB+= EXPECT_VER=${PORTVERSION} \ >>> LIBEXPECT_VER=${LIBEXPECT_VER} >> >> [snip] >> >> This line, "CONFIGURE_ENV= ac_cv_sys_long_file_names=yes" is unrelated >> to tea modification and it should not have been removed. > > Right, it was related to the "minor fixes and modernization" part. My > tests - poudriere runs on 9 and 10, i386 and amd64 - didn't suggest this > was needed. If you have evidence of the contrary, please share your > findings. Poudriere apparently can't detect the file system violation because according to Matt poudriere builds with non-root by default and the user doesn't have the ability to write to /usr/local/lib even though it's attempted. you can detect it with "synth test" though. The configure script writes to /usr/local/lib as part of the conftest to determine if the file system supports long names. This conftest is in violation -- there should be no writing to localbase during the configure and build phases. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5724DB4D.6020009>