From owner-svn-src-head@freebsd.org  Mon Jul  2 16:30:36 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F11E102E95A;
 Mon,  2 Jul 2018 16:30:36 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D30358FB66;
 Mon,  2 Jul 2018 16:30:35 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w62GUV8J034522;
 Mon, 2 Jul 2018 09:30:31 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w62GUVEQ034521;
 Mon, 2 Jul 2018 09:30:31 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201807021630.w62GUVEQ034521@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r335856 - in head/sys: netinet sys
In-Reply-To: <CADrOrmse-LxVcV6oJZErprofTDBxBhPRKxnHm9OOoeGQ0yXHaQ@mail.gmail.com>
To: "Jonathan T. Looney" <jtl@freebsd.org>
Date: Mon, 2 Jul 2018 09:30:31 -0700 (PDT)
CC: steven.hartland@multiplay.co.uk, Matt Macy <mmacy@freebsd.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jul 2018 16:30:36 -0000

[ Charset UTF-8 unsupported, converting... ]
> On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland <
> steven.hartland@multiplay.co.uk> wrote:
> >
> > You have M_WAITOK and a null check in this change
> 
> And, that's the same as the way it was before his commits. So, he did
> exactly what he said he was doing and reverted his commits. I don't think
> it is good practice to mix reverts with other changes.

It is a very bad practive to mix a revert with anything.

> Since you've noticed this, I think you should feel free to make the change.
> Jonathan

-- 
Rod Grimes                                                 rgrimes@freebsd.org