From owner-freebsd-mobile@FreeBSD.ORG Mon Jan 24 02:55:56 2005 Return-Path: Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C027F16A4CE for ; Mon, 24 Jan 2005 02:55:56 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55E7F43D1F for ; Mon, 24 Jan 2005 02:55:56 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id j0O2rKMi080939; Sun, 23 Jan 2005 19:53:22 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 23 Jan 2005 19:54:38 -0700 (MST) Message-Id: <20050123.195438.61400112.imp@bsdimp.com> To: dwalton@acm.org From: "M. Warner Losh" In-Reply-To: <41F02CE1.5090207@acm.org> References: <41EF6101.7010008@acm.org> <41EF6C84.5050608@orel.ru> <41F02CE1.5090207@acm.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: freebsd-mobile@freebsd.org cc: bel@orel.ru Subject: Re: Trouble with APM suspend in 5.3-R X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2005 02:55:56 -0000 In message: <41F02CE1.5090207@acm.org> Dave Walton writes: : Andrew Belashov wrote: : > Dave Walton wrote: : > : >> I've been unable to get APM suspend/resume to work with 5.3-R on my : >> Thinkpad 770Z. As released, 'apm -z' causes a lockup (it worked fine : >> in 4.x). Revision 1.233 of ata-all.c fixes that, and 'apm -z' now : >> causes the system to properly suspend to disk, as it had before. : >> However, when the system resumes, it spits out three errors regarding : >> pir0, then panics. This happens with or without your patch applied to : >> ata-all.c. : >> : > : > Try attached patch as workaround. : : A good effort! That is precisely the error I saw. Hopefully, that : removed call to pci_pir_biosroute() doesn't do anything important. : : Unfortunately, this had no effect at all on the panic. Please see my : next reply to Gleb Smirnoff for details on the panic. Perhaps it will : mean something to you. Chances are the right fix is to try the route, but ignore errors... I've found problems like this in the pci code in the past and worked around it this way (becaues it breaks some machines if you don't even try). Warner