From owner-svn-src-all@FreeBSD.ORG  Wed Jul  8 08:16:30 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9F9871065670;
	Wed,  8 Jul 2009 08:16:30 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 629F28FC1E;
	Wed,  8 Jul 2009 08:16:30 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.64.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 052F369959;
	Wed,  8 Jul 2009 07:58:20 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.3/8.14.3) with ESMTP id n687wKut092654;
	Wed, 8 Jul 2009 07:58:20 GMT (envelope-from phk@critter.freebsd.dk)
To: Marcel Moolenaar <marcel@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 08 Jul 2009 05:56:14 GMT."
	<200907080556.n685uFsn040044@svn.freebsd.org> 
Date: Wed, 08 Jul 2009 07:58:20 +0000
Message-ID: <92653.1247039900@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r195436 - in head/sys: dev/ata geom geom/part sys 
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2009 08:16:31 -0000

In message <200907080556.n685uFsn040044@svn.freebsd.org>, Marcel Moolenaar writ
es:

>Log:
>  Revert revisions 188839 and 188868. Use of the ioctl in geom_dev.c
>  is invalid because the ioctl happens without prior open. The ioctl
>  got introduced to provide backward compatibility for extended
>  partitions, but it ended up not being used because it didn't work
>  as expected. Since there are no consumers of the ioctl and the
>  implementation is broken, the best fix is to remove the code
>  entirely.
>  
>  Spotted by:	phk

For the record
	Really spotted by:	scottl

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.