From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 12 13:30:14 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D9338106566B for ; Mon, 12 Sep 2011 13:30:14 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B55808FC0C for ; Mon, 12 Sep 2011 13:30:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p8CDUErE039068 for ; Mon, 12 Sep 2011 13:30:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p8CDUEWL039063; Mon, 12 Sep 2011 13:30:14 GMT (envelope-from gnats) Resent-Date: Mon, 12 Sep 2011 13:30:14 GMT Resent-Message-Id: <201109121330.p8CDUEWL039063@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Stanisław Halik" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C2DE106564A for ; Mon, 12 Sep 2011 13:22:41 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id D68148FC08 for ; Mon, 12 Sep 2011 13:22:40 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8CDMe6Q027191 for ; Mon, 12 Sep 2011 13:22:40 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p8CDMec3027178; Mon, 12 Sep 2011 13:22:40 GMT (envelope-from nobody) Message-Id: <201109121322.p8CDMec3027178@red.freebsd.org> Date: Mon, 12 Sep 2011 13:22:40 GMT From: "Stanisław Halik" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/160677: dns/noip has garbled interface list X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2011 13:30:14 -0000 >Number: 160677 >Category: ports >Synopsis: dns/noip has garbled interface list >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Sep 12 13:30:13 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Stanisław Halik >Release: 8.2-p2 >Organization: private >Environment: FreeBSD kronstadt.local 8.2-RELEASE-p2 FreeBSD 8.2-RELEASE-p2 #0: Fri Sep 9 05:24:27 CEST 2011 root@kronstadt.local:/usr/obj/usr/src/sys/KRONSTADT i386 >Description: The dns/noip ports needs to have -Dbsd_with_getifaddrs passed during the compilation stage. The current port attempts to account for it by setting CFLAGS, yet it is unsupported by the port's Makefile. The following is a patch (actually identical to ports/155974 in functionality) for this. The interface list is no longer garbled which randomly prevented the user from selecting some of the interfaces from the list. Also, as per ehaupt@'s suggestion, I'm stepping up with a request for maintainership of the port, as he no longer uses it. >How-To-Repeat: Compile, then run noip2 as "noip2 -C /tmp/foo". The initial interface list will contain non-ASCII characters as well as empty fields. Sometimes an desired interface will be 'clean' despite that, sometimes not. >Fix: Diff attached. Patch attached with submission follows: diff -ur noip-old/Makefile noip/Makefile --- noip-old/Makefile 2011-09-12 13:54:34.000000000 +0200 +++ noip/Makefile 2011-09-12 14:58:15.000000000 +0200 @@ -22,8 +22,6 @@ LICENSE= GPLv2 -CFLAGS+= -Dbsd_with_getifaddrs - USERS= noip GROUPS= noip diff -ur noip-old/files/patch-Makefile noip/files/patch-Makefile --- noip-old/files/patch-Makefile 2011-09-12 13:54:33.000000000 +0200 +++ noip/files/patch-Makefile 2011-09-12 15:00:34.000000000 +0200 @@ -1,9 +1,8 @@ ---- Makefile.orig 2008-11-21 23:27:15.000000000 +0100 -+++ Makefile 2011-03-28 18:15:31.000000000 +0200 -@@ -1,8 +1,8 @@ +--- ./Makefile.orig 2008-11-21 23:27:15.000000000 +0100 ++++ ./Makefile 2011-09-12 15:00:30.000000000 +0200 +@@ -1,8 +1,7 @@ TGT=noip2 -CC=gcc -+CC?=gcc PKG=noip-2.1.tgz -PREFIX=/usr/local @@ -11,21 +10,12 @@ CONFDIR=${PREFIX}/etc BINDIR=${PREFIX}/bin -@@ -11,7 +11,7 @@ - ARCH=linux - - # for Mac OS X and BSD systems that have getifaddr(), uncomment the next line --#ARCH=bsd_with_getifaddrs -+ARCH=bsd_with_getifaddrs - - # for early BSD systems without getifaddrs(), uncomment the next line - #ARCH=bsd -@@ -22,7 +22,7 @@ +@@ -22,7 +21,7 @@ # ARCH=sun ${TGT}: Makefile ${TGT}.c - ${CC} -Wall -g -D${ARCH} -DPREFIX=\"${PREFIX}\" ${TGT}.c -o ${TGT} ${LIBS} -+ ${CC} ${CFLAGS} -DPREFIX=\"${PREFIX}\" ${TGT}.c -o ${TGT} ${LIBS} ++ ${CC} -Dbsd_with_getifaddrs -DPREFIX=\"${PREFIX}\" ${TGT}.c -o ${TGT} ${LIBS} install: ${TGT} if [ ! -d ${BINDIR} ]; then mkdir -p ${BINDIR};fi diff -ur noip-old/files/patch-noip2.c noip/files/patch-noip2.c --- noip-old/files/patch-noip2.c 2011-09-12 13:54:33.000000000 +0200 +++ noip/files/patch-noip2.c 2011-09-12 15:00:34.000000000 +0200 @@ -1,5 +1,5 @@ ---- noip2.c.orig 2009-11-17 20:23:40.000000000 +0100 -+++ noip2.c 2009-11-17 20:27:45.000000000 +0100 +--- ./noip2.c.orig 2008-11-21 23:19:54.000000000 +0100 ++++ ./noip2.c 2011-09-12 14:58:30.000000000 +0200 @@ -198,7 +198,7 @@ #define CLIENT_IP_PORT 8245 >Release-Note: >Audit-Trail: >Unformatted: