From owner-freebsd-arch@FreeBSD.ORG Fri Mar 26 09:15:35 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DB48106566B; Fri, 26 Mar 2010 09:15:35 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 140548FC17; Fri, 26 Mar 2010 09:15:34 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2C1F3.dip.t-dialin.net [217.226.193.243]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 5F92C844054; Fri, 26 Mar 2010 10:15:28 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 309425112; Fri, 26 Mar 2010 10:15:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1269594925; bh=5SQqbrXikZid6oSBpz9ejX7Q61lJhwT7PqBGXljn4mY=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=VQO0R8XvJrgsS79Pr1ktl++jAtoEG3AysJxa1+oufdmvOhpsefMD1L9l9JfojsWKs xAPRvVUtreR9y4Vmc4qkN012C2DYUexDrTrQXe//fjk/zZK54x9nQ+R6bS+R03Vtkb obYYcKcGu/Sk7SLmaAfEPoD8SCitgIdyyQ1ENTMLbgQZgwBUlgAVTfDwn09QmoDGY2 NuWw91QNHU/2RIlYxnji+jNOscKQmlbAmCKlo97W6yQtOgLRqfSHVQ7aCPMNTY4Bnn HvefK9U5h6BOlUH4JXGjn1osWQu9/ZfBko/nG6asVTmFST3NALjFqhSR0OAjsRLUgW J/reaqmwCx4sg== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o2Q9FOgT001390; Fri, 26 Mar 2010 10:15:24 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Fri, 26 Mar 2010 10:15:24 +0100 Message-ID: <20100326101524.15695bisy2324t8g@webmail.leidinger.net> Date: Fri, 26 Mar 2010 10:15:24 +0100 From: Alexander Leidinger To: "M. Warner Losh" References: <201003241132.29588.jhb@freebsd.org> <20100325105615.10186jr08a5oj00s@webmail.leidinger.net> <201003250749.57994.jhb@freebsd.org> <20100325.073736.635700942514937954.imp@bsdimp.com> In-Reply-To: <20100325.073736.635700942514937954.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 5F92C844054.10FDF X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.44, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1270199730.81069@+FOTgcwzzgGo6Yfl8GGmbA X-EBL-Spam-Status: No Cc: rwatson@FreeBSD.org, jhb@FreeBSD.org, freebsd-arch@FreeBSD.org Subject: Re: CTF patch for testing/review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 09:15:35 -0000 Quoting "M. Warner Losh" (from Thu, 25 Mar 2010 07:37:36 -0600 (MDT)): > In general, I think this is OK. I'd like to see the revised patch > before it is committed. And here it is: http://www.Leidinger.net/test/ctf3.diff My commit log would be something like this: ---snip--- WITH_CTF can now be specified in src.conf (not recommended, there are some problems with static executables), make.conf (would also affect ports which do not use GNU make and do not override the compile targets) or in the kernel config (via "makeoptions WITH_CTF=yes"). Additional (related) changes: - propagate WITH_CTF to module builds - do not add -g to the linker flags, it's a noop there anyway (at least according to the man page of ld) - do not add -g yo CFLAGS unconditionally we need to have a look if it is really needed (IMO not) or if there is a way to add it only when WITH_CTF is used Note: don't worry when you see ctfconvert lines appearing in your build, they are protected with a shell conditional and are not run as long as you don't have WITH_CTF defined. Reviewed by: imp, jhb, scottl (earlier version) Discussed on: arch@ ---snip--- If nobody comes up with problems (or wants more time for the review): I would like to commit this next week. Bye, Alexander. -- We are each only one drop in a great ocean -- but some of the drops sparkle! http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137