From owner-freebsd-net@FreeBSD.ORG Thu Apr 3 01:24:28 2014 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9DF04163 for ; Thu, 3 Apr 2014 01:24:28 +0000 (UTC) Received: from mail-wi0-x234.google.com (mail-wi0-x234.google.com [IPv6:2a00:1450:400c:c05::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A00133F for ; Thu, 3 Apr 2014 01:24:28 +0000 (UTC) Received: by mail-wi0-f180.google.com with SMTP id q5so1556647wiv.13 for ; Wed, 02 Apr 2014 18:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=AE9yD79/CDES9UQ4Rb5Xo/w+kRJGJcMpHeOY9uT6Bsw=; b=IytboadpEe8Nz/ehYiIST9oozEFl7MLXQwZ/77shKtSi9qcHRE7J/u+j+AkbKweMhI xcG8PnMAahQFX9wTQ+0Czw8imgQjPGdoMSR6GLL67xhAEEV+9a+GbQSODxDWdJodNHpr avSNTM2Zzmbg76klzm7YGhNcNC7kak7uiQR6EjlEVD6GVo+JGMclNoTwRMcESlyJ2lNs 8BJbiMxQlGxuHC9jdyJu6u6ovrXECCNE7JAl9AuNV2XdplUE6q4wuiOoHpEf4W+NyvaG MhM0LuKII0hOx1ptglcIUPPuwcQRy3GA9b1py+KeNEew/52Y9E3OC+rJ8Jrb/u4XQdWE zpGg== MIME-Version: 1.0 X-Received: by 10.194.238.231 with SMTP id vn7mr5240824wjc.76.1396488265661; Wed, 02 Apr 2014 18:24:25 -0700 (PDT) Received: by 10.14.211.134 with HTTP; Wed, 2 Apr 2014 18:24:25 -0700 (PDT) In-Reply-To: <5338FF05.1020302@sfc.wide.ad.jp> References: <5338FF05.1020302@sfc.wide.ad.jp> Date: Wed, 2 Apr 2014 18:24:25 -0700 Message-ID: Subject: Re: DCTCP implementation From: hiren panchasara To: Midori Kato Content-Type: text/plain; charset=UTF-8 Cc: "Eggert, Lars" , "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Apr 2014 01:24:28 -0000 On Sun, Mar 30, 2014 at 10:37 PM, Midori Kato wrote: > Hi FreeBSD developpers, > > I'm Midori Kato. I'm working on the DCTCP implementation in the FreeBSD with > Lars Eggert. I mail you because I would like to ask you a code review and > testing. The attached patch is not good enough to test our code. Please give > me your message. I will send an ECN marking implmenetation in dummynet and > test scripts personally to you. Midori, First thing I noticed in your dctcp.patch is that you are dropping r256920 which adds a new argument tlen to DELAY_ACK() macro. I also see you removed and re-added that macro definition without any changes to it. Is that intentional? If not, can you please fix that and resend the patch? It is usually a good idea to work on -HEAD for such things so patching/committing is easier. cheers, Hiren