Date: Mon, 20 Dec 2004 08:37:36 -0800 From: "Kevin Oberman" <oberman@es.net> To: Nate Lawson <nate@root.org> Cc: freebsd-acpi@freebsd.org Subject: Re: Improper failure declarations for cmbat Message-ID: <20041220163737.60FC05D09@ptavv.es.net> In-Reply-To: Your message of "Sun, 19 Dec 2004 21:04:13 PST." <41C65D4D.8030807@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Date: Sun, 19 Dec 2004 21:04:13 -0800 > From: Nate Lawson <nate@root.org> > > Kevin Oberman wrote: > > I have an IBM T30 with 2 batteries. Yesterday I was running on battery > > for a while and completely exhausted the secondary battery. The primary > > never dropped below about 75%. > > > > When the secondary dropped, acpi_cmbat1 started spitting out large > > numbers of errors. > > acpi_cmbat1: critically low charge! > > While the messages are correct, they are not really appropriate when the > > primary battery is fully charged and is both annoying and fills up the > > log, possibly causing "real" messages to be missed. I would suggest that > > no battery critical warning be issued unless all batteries are critical. > > Thanks for the bug report. I just committed a small fix to only report > the message once. Checking all batteries is a larger change that we can > examine in the future. Nate, Thanks for the quick fix! I don't see and MFC entry on the patch. Would that be possible (in a few days, of course)? -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041220163737.60FC05D09>