From owner-freebsd-net@freebsd.org Wed Oct 7 16:45:27 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F123B4332D9; Wed, 7 Oct 2020 16:45:27 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C60ZH6BHZz3XHP; Wed, 7 Oct 2020 16:45:27 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id B354617902; Wed, 7 Oct 2020 16:45:27 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f179.google.com with SMTP id c23so2474236qtp.0; Wed, 07 Oct 2020 09:45:27 -0700 (PDT) X-Gm-Message-State: AOAM530Ym/zQeOlR26mXNIj2eRX0SrevAzK+OHDgaCnyFzeFD1r4yytZ OKPuYBY2N2zMtpQRywgvjnCJvmt1Bt4UP+Btt5Q= X-Google-Smtp-Source: ABdhPJxpnjTDdZC4PSyyC6gntcASGvRc4yq0lNEENqowdTtUfyDaqQkX5azCS4ff48tCskW7NUrn74E7NzNKeJDTbuM= X-Received: by 2002:ac8:3975:: with SMTP id t50mr4150020qtb.53.1602089127208; Wed, 07 Oct 2020 09:45:27 -0700 (PDT) MIME-Version: 1.0 From: Kyle Evans Date: Wed, 7 Oct 2020 11:45:16 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Domain Patches To: freebsd-net , FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2020 16:45:28 -0000 Hi, I have a couple of domain patches in review, if anyone would like to comment/review the area: https://reviews.freebsd.org/D25062 adds a dom_probe callback so that domains can indicate whether they should be supported at all or not. This avoids some dirty stuff in domains that may not be supported based on the hardware that's present (e.g. hvsock included in the review, which shouldn't be available outside of HyperV). Instead of having to account for circumstances like that in individual callbacks, this is a single hammer to prevent any further reach into the domain. D25062 also updates domain(9) to reflect some changes from the past 11 years (splitting initialization out into domain_init, dom_destroy addition). https://reviews.freebsd.org/D25459 should make it safe to add domains after domainfinalize (i.e. they can be loadable at runtime). The big issue with doing this previously is that pfslowtimo/pffasttimo have already been setup and may be called on domains that aren't completely initialized. There are some additional races re: socket creation that should be addressed, but this review should be sufficient for at least removing the warning. Thanks, Kyle Evans