From owner-svn-src-all@freebsd.org Thu May 24 22:51:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 250A0F6B814; Thu, 24 May 2018 22:51:12 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C9140683C7; Thu, 24 May 2018 22:51:11 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f48.google.com (mail-it0-f48.google.com [209.85.214.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 8E55714921; Thu, 24 May 2018 22:51:11 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f48.google.com with SMTP id 144-v6so4493839iti.5; Thu, 24 May 2018 15:51:11 -0700 (PDT) X-Gm-Message-State: ALKqPwfNTC4t7W1azTiKkG7UXaF15ljUuTdrQ2h3d9wF+BWVwG7jZhvV AAhNWh5klVSCFUt1udFy8MHKLs15WlkwwXhtF2Q= X-Google-Smtp-Source: ADUXVKIDbU+bMFQxKvxw5fo4jVmvdPlbdJqA2JeR9mi+JXfnbsUMrXlYHSbB6LsK/8qS3X3DmF9i+4zLZTnlc/pRLrw= X-Received: by 2002:a24:29cc:: with SMTP id p195-v6mr2553602itp.132.1527202271111; Thu, 24 May 2018 15:51:11 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:85ca:0:0:0:0:0 with HTTP; Thu, 24 May 2018 15:51:10 -0700 (PDT) In-Reply-To: <2291583.vLXA4fx7TA@ralph.baldwin.cx> References: <201805240430.w4O4U6Js001134@repo.freebsd.org> <2291583.vLXA4fx7TA@ralph.baldwin.cx> From: Matthew Macy Date: Thu, 24 May 2018 15:51:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcstat... To: John Baldwin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 22:51:12 -0000 On Thu, May 24, 2018 at 3:36 PM, John Baldwin wrote: > On Thursday, May 24, 2018 04:30:06 AM Matt Macy wrote: >> Author: mmacy >> Date: Thu May 24 04:30:06 2018 >> New Revision: 334128 >> URL: https://svnweb.freebsd.org/changeset/base/334128 >> >> Log: >> libpmcstat: compile in events based on json description > > Please provide more detail for commits like this in the future. Some questions > I have some of which probably should have been answered in the log: > > - Why does this matter? For example, does this provide counters for a CPUs > we don't currently support counters on? > - Does this supplant the existing tables of counters in hwpmc or is this > a different set of counters (or how do these counter tables interact with > our existing tables in general)? > - What is the origin of these json files? What is the license? These seem to > come straight from the Linux kernel which should be acknowledged via > Obtained from: at the very least. It does seem that the jevents source is > explicitly BSD licensed (2 clause). This is noted in the git logs in the > Linux tree. However, I couldn't find a clear statement on the json files > themselves and what their license is. Are you aware of a license for those > or do they fall under the GPLv2 "default" license in /COPYING of the Linux > source tree? At least the Intel ones come from Intel where everything is BSD licensed. If the others are GPL I'll move it all to a port.