From owner-svn-ports-all@freebsd.org Sat May 21 17:11:26 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70581B45F78; Sat, 21 May 2016 17:11:26 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "apnoea.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B2E851B34; Sat, 21 May 2016 17:11:25 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id e1872ccc TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO; Sat, 21 May 2016 11:11:17 -0600 (MDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r415078 - in head: . Mk From: Adam Weinberger In-Reply-To: <20160521162931.GA97771@FreeBSD.org> Date: Sat, 21 May 2016 11:11:12 -0600 Cc: Baptiste Daroussin , marino@freebsd.org, Ed Maste , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <43145C09-EC33-4738-9FE7-5DC34A74D64B@adamw.org> References: <201605121820.u4CIKROJ004026@repo.freebsd.org> <20160513160151.GA30219@FreeBSD.org> <20160513182837.GF49383@ivaldir.etoilebsd.net> <20160513201919.GA48945@FreeBSD.org> <20160519122306.GA24015@FreeBSD.org> <20160521112728.GA624@FreeBSD.org> <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st> <20160521114358.GC624@FreeBSD.org> <20160521122522.GJ21899@ivaldir.etoilebsd.net> <20160521162931.GA97771@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 May 2016 17:11:26 -0000 > On 21 May, 2016, at 10:29, Alexey Dokuchaev wrote: >=20 > On Sat, May 21, 2016 at 02:25:22PM +0200, Baptiste Daroussin wrote: >> On Sat, May 21, 2016 at 11:43:58AM +0000, Alexey Dokuchaev wrote: >>> On Sat, May 21, 2016 at 01:33:36PM +0200, John Marino wrote: >>>> On 5/21/2016 1:27 PM, Alexey Dokuchaev wrote: >>>>> On Thu, May 19, 2016 at 12:23:06PM +0000, Alexey Dokuchaev wrote: >>>>>> ... >>>>>> I'm still not convinced though, sorry. Ports tree can be = obtained by >>>>>> a number of means, but this new ugly TIMESTAMP thingy is added = for a >>>>>> very specific usecase, and there should be no problem to require = that >>>>>> for that particular usecase, exported ports tree must have its = files' >>>>>> mtimes correctly set. (If svn/git/hg are not setting right = mtimes on >>>>>> export, they should be fixed.) It looks more like quick'n'dirty = hack >>>>>> rather than thoroughly thought-out solution. >>>>>=20 >>>>> Given lack of replies, I guess I'd have to elaborate a bit on = problems >>>>> with TIMESTAMP and why I'm against it. >>>>>=20 >>>>> 1. It does not line up with distinfo format... >>>>> 2. It is not needed even if ports repo is obtained as tarball... >>>>=20 >>>> Maybe it could/should be implemented as a makefile variable = instead? >>>>=20 >>>> e.g. REP_TIMESTAMP=3D >>>>=20 >>>> Just a suggestion. I don't disagree with you. >>>=20 >>> While still hackish, it's a *lot* less ugly and bogus as tainting = distinfo. >>> (New variable in Makefile is OK because that's what Makefiles are = made of: >>> variables, targets, and recipes. Adding TIMESTAMP to distinfo is = NOT OK >>> because distinfo describes port's distfiles in a form of FOO(), = BAR(), ... >>> values per each distfile.) >>=20 >> Implementing it as a Makefile variable would make it not = automatically >> updated. >=20 > Even if we can agree on REP_TIMESTAMP variable, why `make makesum' = cannot > sed -i the Makefile? Oh god, please, no. Please do not mess with Makefiles. Rather than having it come from 'makesum', can an svn hook write it to = distinfo? May help it stay more current. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org