From owner-dev-commits-src-main@freebsd.org Tue Dec 29 17:48:28 2020 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6B7CC4C63D1 for ; Tue, 29 Dec 2020 17:48:28 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D522h2VDJz4scm for ; Tue, 29 Dec 2020 17:48:28 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f50.google.com with SMTP id i9so15304919wrc.4 for ; Tue, 29 Dec 2020 09:48:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=48pfkgaZO3pUJS3SgSMUx8uXYBWh2I8UdwogqxxRONc=; b=JEk+HVM0VEoexMtKV0ZyJe2cIX14YyIH8DdEUakW083oahK3314NGsYBG94PKRIOQw Q13pctHZIeZOU68lBcMT+m/qKgrGZMnZZDHvYVC2/4coQ58q/oDOoBvEiPx/9SxLYF90 Syt8zAHSp5SKqFH/oSVvKs+6Y3XwyvYniJ2EJHEgmAmvvnsAUZ8JoX2VvD7qRyWApTc6 iPuJdiR2kbdfiDm8vmMHUv5JK+eVY94imMQPX8IGiRSSy2+WWjitlF74vDMHXrgEAJoD ZMcrcNtIEotBncElsE4D9kjPYNPsYmsRD492DruFF/TAmOSLk1vUAesEu5xkMflZv3XY 6uiQ== X-Gm-Message-State: AOAM532I4isBHM/Jcdd108N5YIBrCm6plwKZrxR7WJkzDuHL15qvhTPK uIhGLXzz9O47u3ebetiOcg2+dQ== X-Google-Smtp-Source: ABdhPJw8FmgZf+QlA2ZFmkSQ6t/OIZHtaka5PgFhfDaOxbAi/MaXraClf0dZd6ZJV4JP+i9IZXSU8Q== X-Received: by 2002:adf:fbd2:: with SMTP id d18mr57432396wrs.222.1609264106687; Tue, 29 Dec 2020 09:48:26 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id c7sm69082425wro.16.2020.12.29.09.48.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Dec 2020 09:48:26 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: ee938b20335d - main - kern: efirt: correct configuration table entry size From: Jessica Clarke In-Reply-To: <202012291739.0BTHd2ji001052@gitrepo.freebsd.org> Date: Tue, 29 Dec 2020 17:48:25 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: 7bit Message-Id: References: <202012291739.0BTHd2ji001052@gitrepo.freebsd.org> To: Kyle Evans X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4D522h2VDJz4scm X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for the main branch of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2020 17:48:28 -0000 On 29 Dec 2020, at 17:39, Kyle Evans wrote: > diff --git a/sys/sys/efi.h b/sys/sys/efi.h > index b9f31454efff..220509853cb2 100644 > --- a/sys/sys/efi.h > +++ b/sys/sys/efi.h > @@ -52,7 +52,7 @@ typedef unsigned long efi_status; > > struct efi_cfgtbl { > struct uuid ct_uuid; > - uint64_t ct_data; > + void *ct_data; Hm, this should probably be a u_long/vm_offset_t/vm_paddr_t (though the tables are unlikely to be in places where you need PAE so even if technically correct, vm_paddr_t probably just makes things more awkward for no gain) given it's not a real pointer that can be dereferenced. Jess