From owner-freebsd-jail@FreeBSD.ORG Sat Nov 17 16:31:55 2012 Return-Path: Delivered-To: freebsd-jail@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 55A705A8 for ; Sat, 17 Nov 2012 16:31:55 +0000 (UTC) (envelope-from edschouten@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 112838FC0C for ; Sat, 17 Nov 2012 16:31:54 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id 16so4677013obc.13 for ; Sat, 17 Nov 2012 08:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=EejD0Qe4P2fOITY6z7eCsWOiKbgyQYmuH2zynmHNQ2M=; b=UR1TgT1W3TXyqHZej0UqHYX3UyITeI0NpI9KFuW261ErulHlCaBUNKC4sAXt9lVb0p Ov3+izLaEkEjsfqwEA9zekDYklL7mq6dSvb6PJtYWGMyrO08Mlec/kEiQXH0V5vvgral UKVXAGyAU/XPJVpWXbBdZM6WP9tvGz0Y7kkKHh+muC4XFqCVozSgcgOTAlKv1GzuJha5 4n61n5BOZMqhcDTsYihupb1hPsY46zOAhPtfzLBBLf+cglKTePolYHjnJ788IdCwOBgT TtPs+q77dNmeXmWKoSXwDuy60STIpSBo3oMNviOGl+OLahb5EhPkBvKGGXiv+xIepf9f kF4A== MIME-Version: 1.0 Received: by 10.60.171.174 with SMTP id av14mr3325241oec.92.1353169914213; Sat, 17 Nov 2012 08:31:54 -0800 (PST) Sender: edschouten@gmail.com Received: by 10.76.151.39 with HTTP; Sat, 17 Nov 2012 08:31:54 -0800 (PST) In-Reply-To: References: <201211171312.qAHDChWT093266@freefall.freebsd.org> Date: Sat, 17 Nov 2012 17:31:54 +0100 X-Google-Sender-Auth: k0HKaV_TZ_BNuDJFMp0-RAKHcnc Message-ID: Subject: Re: bin/32828: [jail] w(1) incorrectly handles stale utmp slots with jail From: Ed Schouten To: Eitan Adler Content-Type: text/plain; charset=UTF-8 Cc: rlucia@iscanet.com, freebsd-jail@freebsd.org X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2012 16:31:55 -0000 Hello Eitan, 2012/11/17 Eitan Adler : > Was the fix MFCed? Well, yes and no. There are actually three separate changes here: 1. The visibility of pseudo-terminals. On FreeBSD 8 and later, pseudo-terminals are only shown in devfs if they belong to your jail or one of its descendants. 2. If you set cleanvar_enable="YES" your utx.active file will already be discarded on startup, meaning any stale entries won't survive a reboot. 3. r231534 moves the unconditional initialisation of utx.active with a BOOT_TIME entry out of init(8) into an rc script, so you don't need cleanvar_enable="YES". I'm not planning on MFCing the latter, as FreeBSD 9's utmpx does not write BOOT_TIME entries in utx.active to begin with, so merging back r231534 is useless. Given the fact that the first two changes already effectively fix this issue, I consider this bug fixed. -- Ed Schouten