From owner-freebsd-hackers@FreeBSD.ORG Wed Nov 30 21:55:55 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3644106566C for ; Wed, 30 Nov 2011 21:55:55 +0000 (UTC) (envelope-from ml@my.gd) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 75FFD8FC19 for ; Wed, 30 Nov 2011 21:55:55 +0000 (UTC) Received: by bkat2 with SMTP id t2so1333599bka.13 for ; Wed, 30 Nov 2011 13:55:54 -0800 (PST) Received: by 10.205.127.77 with SMTP id gz13mr4320751bkc.76.1322688521723; Wed, 30 Nov 2011 13:28:41 -0800 (PST) Received: from dfleuriot.local ([2a01:e35:2f1b:d6f0:e6ce:8fff:fe15:741a]) by mx.google.com with ESMTPS id hw14sm6651857bkc.16.2011.11.30.13.28.37 (version=SSLv3 cipher=OTHER); Wed, 30 Nov 2011 13:28:38 -0800 (PST) Message-ID: <4ED6A005.60300@my.gd> Date: Wed, 30 Nov 2011 22:28:37 +0100 From: Damien Fleuriot User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org References: <20111125073630.GC7915@DataIX.net> <201111301152.47002.jhb@freebsd.org> <20111130184815.GA70174@DataIX.net> In-Reply-To: <20111130184815.GA70174@DataIX.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: sysctl description spillover and also setting the sysctl ? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2011 21:55:56 -0000 On 11/30/11 7:48 PM, Jason Hellenthal wrote: > > > On Wed, Nov 30, 2011 at 11:52:46AM -0500, John Baldwin wrote: >> On Friday, November 25, 2011 2:36:30 am Jason Hellenthal wrote: >>> >>> Found a troubling result of the following and figured someone might want to >> take a look. >>> >>> Pay close attention to the output and behavior. >>> >>> sysctl net.inet.udp.blackhole=0 >>> sysctl net.inet.udp.blackhole >>> sysctl -d net.inet.udp.blackhole=1 >>> sysctl net.inet.udp.blackhole >>> >>> >>> Is this expected ? should it not just display the description instead of >> adjusting ? as well not display the description like it is adjusting the >> description too ? >> >> Hah, cute. It should probably fail with an error if you do something like >> that, yes. >> > > Yeah thats what I thought about it to but the more I thought about it, if it just displayed the values changing instead of the description when =N is supplied I think that would be acceptable to. 0 -> 1 in this case. Or possibly sys.oid: 0 -> 1 # since sysctl.conf(5) also takes comments like that. > > Not really thats something at the top of the list for fixes though. Low fruit. Food for thought. > Perhaps you would kindly provide a patch for this ? I might have a look at it if nobody does, sounds trivial enough that I might be able to handle it ;)