From owner-freebsd-current@freebsd.org Wed Apr 11 19:06:43 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54C2DF88E71 for ; Wed, 11 Apr 2018 19:06:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAF2482F5D for ; Wed, 11 Apr 2018 19:06:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x232.google.com with SMTP id 142-v6so4158138itl.5 for ; Wed, 11 Apr 2018 12:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/SLwPxDPQXnWwMdqa1iXpwb24LSZlOWkVFYlPsBI7BQ=; b=0BFzAfBEUxlbOS/gMpEocMtm9dAGsjn665xGU58ZGgxOiA4D7J3QHniebWNSpgKfta Wn+vopiEqO27xmj9mhlwVwXYJEQqTRg9+v7AACrTTr98O+GZCriUrv2sRFeWo3Odxeot 4kRLCm46k3jfFTkOgQ13f7xuG2XFWG4jTJBl69s6T1Vm+DTLikPPZzhhHS354dLJqDlC peV6kOqH21pcM2ptr3N6QtKQQI76Kx7thEZKTje9Dq5AjxqEZB4W30L+12e2dsQk0Pn/ SQRoq4XlFXeNwjeMMJbrou6K6JHnOOUXPwBsF0DW4u57troShSEoaznsBZFQgiKZswFW 4DQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/SLwPxDPQXnWwMdqa1iXpwb24LSZlOWkVFYlPsBI7BQ=; b=NKtfAkgNnaeG8iJYYufu2AfkQF0sGPXjnPf93pyEMP651S4qHUV+6VIN36340i/CBr 1sVs+oXeSumsL7JVomfaIzlfvgGckdCrwqw+06kfJemSClduUfV8ye0uQD8IWDtWv4Ek lm7TDBXDu/bNxHaI/qZF5/rSVYsGgeW4YAcjiI+TbhuPNu4ZZfjZnayLfCRjh0qwc9d5 nUX4S/sojim/yqX61HCjsFkPHQj1lkFyUT7Ut3BwNADn8Thi33bsUMMwmySCgeO4rxxz 7SDa+Vp+xe+JIL+ylWYwMlQ0To/g766vgPdZWEfcQAbXrVZdb+fok+unTFmFwDsU6B6S 5Vow== X-Gm-Message-State: ALQs6tDfLP4dJAxlIQfSmShA9/w5FpmnrsIWMEjxdMGrZA1yGPYwRSGP /u94W0uSFcvmGEvRDGBrLNWQwAU/2DzdJmcZXb/axg== X-Google-Smtp-Source: AIpwx49OXu9RC1F4yOGGvLfUJOcrLZ+POPz/qfHFMEWJz4CYwePI4ebG8Eu9iQLLEiyZX6kim7K/yynHeHn0YO5z/Dg= X-Received: by 2002:a24:4286:: with SMTP id i128-v6mr5377435itb.73.1523473601963; Wed, 11 Apr 2018 12:06:41 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.166.4 with HTTP; Wed, 11 Apr 2018 12:06:41 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <0e75a2ba-9a59-8301-a678-68a822025bd6@metricspace.net> <9df63df2-9d61-4106-f360-347411869b41@metricspace.net> From: Warner Losh Date: Wed, 11 Apr 2018 13:06:41 -0600 X-Google-Sender-Auth: VB0KO18zIsw3HX1GaiNVNPWy98U Message-ID: Subject: Re: GELI with UEFI supporting Boot Environments goes to HEAD when? To: Oliver Pinter Cc: Eric McCorkle , Tommi Pernila , "[ScaleEngine] Allan Jude" , freebsd-current , Warner Losh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 19:06:43 -0000 Still reviewing the code. I'm worried it's too i386 specific and it conflicts with some work I'm doing. I'll have a list of actionable critiques this week. Warner On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter < oliver.pinter@hardenedbsd.org> wrote: > Hi! > > Is there any update regarding the rebase or the inclusion to base system? > On 3/28/18, Eric McCorkle wrote: > > I'll do another rebase from head just to be sure > > > > On March 28, 2018 3:23:23 PM EDT, Warner Losh wrote: > >>It's on my list for nexr, finally. I have an alternate patch for > >>loader.efi > >>from ESP, but i don't think it will affect the GELI stuff. I have some > >>time > >>slotted for integration issues though. > >> > >>I am quite mindful of the freeze dates.... I have some uefi boot > >>loader > >>protocol changes that I need to get in. > >> > >>Warner > >> > >>On Feb 21, 2018 11:18 PM, "Tommi Pernila" wrote: > >> > >>> Awesome, thanks for the update and the work that you have done! > >>> > >>> Now we just need some more reviewers eyes on the code :) > >>> > >>> Br, > >>> > >>> Tommi > >>> > >>> On Thu, 22 Feb 2018 at 2.03, Eric McCorkle > >>wrote: > >>> > >>>> FYI, I just IFC'ed everything, and the current patches are still > >>fine. > >>>> > >>>> Also, the full GELI + standalone loader has been deployed on one of > >>my > >>>> laptops for some time now. > >>>> > >>>> On 02/21/2018 18:15, Eric McCorkle wrote: > >>>> > The GELI work could be merged at this point, though it won't be > >>usable > >>>> > without an additional patch to enable loader-only operation. The > >>>> > patches are currently up for review: > >>>> > > >>>> > This is the order in which they'd need to be merged: > >>>> > > >>>> > > >>>> > https://reviews.freebsd.org/D12732 > >>>> > > >>>> > This one changes the efipart device. Toomas Soome identified some > >>>> > problems, which I have addressed. He has not re-reviewed it, > >>however. > >>>> > > >>>> > > >>>> > https://reviews.freebsd.org/D12692 > >>>> > > >>>> > This adds some crypto code needed for GELI. It simply adds new > >>code, > >>>> > and doesn't conflict with anything. > >>>> > > >>>> > > >>>> > https://reviews.freebsd.org/D12698 > >>>> > > >>>> > This adds the EFI KMS interface code, and has the EFI loader pass > >>keys > >>>> > into the keybuf interface. > >>>> > > >>>> > > >>>> > I can't post the main GELI driver until those get merged, as it > >>depends > >>>> > on them. It can be found on the geli branch on my github freebsd > >>>> > repository, however. > >>>> > > >>>> > > >>>> > Additionally, you need this patch, which allows loader.efi to > >>function > >>>> > when installed directly to the ESP: > >>>> > > >>>> > https://reviews.freebsd.org/D13497 > >>>> > > >>>> > On 02/20/2018 22:56, Tommi Pernila wrote: > >>>> >> Hi Eric, > >>>> >> > >>>> >> could you provide a brief update how the work is going? > >>>> >> > >>>> >> > >>>> >> Br, > >>>> >> > >>>> >> Tommi > >>>> >> > >>>> >> > >>>> >> On Nov 16, 2017 04:29, "Eric McCorkle" >>>> >> > wrote: > >>>> >> > >>>> >> Right, so basically, the remaining GELI patches are against > >>>> loader, and > >>>> >> most of them can go in independently of the work on removing > >>boot1. > >>>> >> There's a unanimous consensus on getting rid of boot1 which > >>>> includes its > >>>> >> original author, so that's going to happen. > >>>> >> > >>>> >> > >>>> >> For GELI, we have the following (not necessarily in order): > >>>> >> > >>>> >> a) Adding the KMS interfaces, pseudo-device, and kernel > >>keybuf > >>>> >> interactions > >>>> >> b) Modifications to the efipart driver > >>>> >> c) boot crypto > >>>> >> d) GELI partition types (not strictly necessary) > >>>> >> > >>>> >> Then there's the GELI driver itself. (a) and (c) are good to > >>>> land, (b) > >>>> >> needs some more work after Toomas Soome pointed out a > >>legitimate > >>>> >> problem, and (d) actually needs a good bit more code (but > >>again, > >>>> it's > >>>> >> more cosmetic). Additionally, the GELI driver will need > >>further > >>>> mods to > >>>> >> efipart to be written (nothing too big). But we could go > >>ahead > >>>> with (a) > >>>> >> and (c), as they've already been proven to work. > >>>> >> > >>>> >> I'd wanted to have this stuff shaped up sooner, but I'm > >>>> preoccupied with > >>>> >> the 7th RISC-V workshop at the end of the month. > >>>> >> > >>>> >> Once this stuff is all in, loader should handle any GELI > >>volumes it > >>>> >> finds, and it should Just Work once boot1 is gone. > >>>> >> > >>>> >> > >>>> > _______________________________________________ > >>>> > freebsd-current@freebsd.org mailing list > >>>> > https://lists.freebsd.org/mailman/listinfo/freebsd-current > >>>> > To unsubscribe, send any mail to "freebsd-current-unsubscribe@ > >>>> freebsd.org" > >>>> > > >>>> > >>> > > > > -- > > Sent from my Android device with K-9 Mail. Please excuse my brevity. > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@ > freebsd.org" > > >