From owner-cvs-sbin Sun Mar 2 11:39:33 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id LAA27242 for cvs-sbin-outgoing; Sun, 2 Mar 1997 11:39:33 -0800 (PST) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id LAA27177; Sun, 2 Mar 1997 11:37:03 -0800 (PST) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <15883(7)>; Sun, 2 Mar 1997 11:36:31 PST Received: from localhost by crevenia.parc.xerox.com with SMTP id <177476>; Sun, 2 Mar 1997 11:36:20 -0800 To: Warner Losh cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/ping ping.c ping.8 In-reply-to: Your message of "Sat, 01 Mar 97 22:32:45 PST." <199703020632.WAA24916@freefall.freebsd.org> Date: Sun, 2 Mar 1997 11:36:07 PST From: Bill Fenner Message-Id: <97Mar2.113620pst.177476@crevenia.parc.xerox.com> Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Warner Losh wrote: > 3) Don't print all replies unless verbose and root (from idea in > OpenBSD ping.c 1.10 and 1.11) to avoid leaking information available > only to root. Is it a good idea to call getuid() for each packet? Wouldn't it make more sense to cache its value, since it's not going to change? (Perhaps at the same time as we setuid(getuid())?) Bill