From owner-svn-src-all@freebsd.org Thu May 19 11:19:38 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD3C8B42C36; Thu, 19 May 2016 11:19:38 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9F6671998; Thu, 19 May 2016 11:19:38 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u4JBJbSK027907; Thu, 19 May 2016 11:19:37 GMT (envelope-from mav@FreeBSD.org) Received: (from mav@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u4JBJb9f027906; Thu, 19 May 2016 11:19:37 GMT (envelope-from mav@FreeBSD.org) Message-Id: <201605191119.u4JBJb9f027906@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mav set sender to mav@FreeBSD.org using -f From: Alexander Motin Date: Thu, 19 May 2016 11:19:37 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r300201 - head/sys/sys X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 11:19:38 -0000 Author: mav Date: Thu May 19 11:19:37 2016 New Revision: 300201 URL: https://svnweb.freebsd.org/changeset/base/300201 Log: Add ta_flags initialization in old macros missed in 300113. Depending on uninitialized memory content it could cause loss of wakeup() call in taskqueue_run_locked(). Modified: head/sys/sys/taskqueue.h Modified: head/sys/sys/taskqueue.h ============================================================================== --- head/sys/sys/taskqueue.h Thu May 19 11:02:39 2016 (r300200) +++ head/sys/sys/taskqueue.h Thu May 19 11:19:37 2016 (r300201) @@ -97,6 +97,7 @@ void taskqueue_set_callback(struct taskq #define TASK_INITIALIZER(priority, func, context) \ { .ta_pending = 0, \ + .ta_flags = 0, \ .ta_priority = (priority), \ .ta_func = (func), \ .ta_context = (context) } @@ -112,6 +113,7 @@ void taskqueue_thread_enqueue(void *cont */ #define TASK_INIT(task, priority, func, context) do { \ (task)->ta_pending = 0; \ + (task)->ta_flags = 0; \ (task)->ta_priority = (priority); \ (task)->ta_func = (func); \ (task)->ta_context = (context); \