From owner-freebsd-net@FreeBSD.ORG  Thu Apr  3 11:27:31 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 64E2DB0B
 for <net@freebsd.org>; Thu,  3 Apr 2014 11:27:31 +0000 (UTC)
Received: from mail.sfc.wide.ad.jp (ns.sfc.wide.ad.jp
 [IPv6:2001:200:0:8803:203:178:142:143])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 34188F1C
 for <net@freebsd.org>; Thu,  3 Apr 2014 11:27:30 +0000 (UTC)
Received: from Midoris-MacBook-Air.local (pa9b06e.tokynt01.ap.so-net.ne.jp
 [182.169.176.110])
 by mail.sfc.wide.ad.jp (Postfix) with ESMTPSA id 0F44D27820D;
 Thu,  3 Apr 2014 20:27:28 +0900 (JST)
Message-ID: <533D459F.8000403@sfc.wide.ad.jp>
Date: Thu, 03 Apr 2014 20:27:27 +0900
From: Midori Kato <katoon@sfc.wide.ad.jp>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: hiren panchasara <hiren.panchasara@gmail.com>
Subject: Re: DCTCP implementation
References: <5338FF05.1020302@sfc.wide.ad.jp>
 <CALCpEUHvD3iUw3FjUL8NNm60nFG9DGmrp4iojRszGD4f2PhgLQ@mail.gmail.com>
In-Reply-To: <CALCpEUHvD3iUw3FjUL8NNm60nFG9DGmrp4iojRszGD4f2PhgLQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Eggert, Lars" <lars@netapp.com>,
 "freebsd-net@freebsd.org" <net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Apr 2014 11:27:31 -0000

Hi Hiren,

Yes, I intentionally replace the location of DELAY_ACK() macro.
A DCTCP receiver sends an immediate ACK when incoming packets sets CE 
and non-CE bit by turns. To implement this processing, I prepare the 
cc_ecnpkt_handler() function. This function calls the DEKAY_ACK() macro 
to check if this packet is in delayed ack or not. This is why I replace 
the macro position.
Let me know if my explanation is not good enough.

Regards,
-- Midori

(4/3/14, 10:24 AM), hiren panchasara wrote:
> On Sun, Mar 30, 2014 at 10:37 PM, Midori Kato <katoon@sfc.wide.ad.jp> wrote:
>> Hi FreeBSD developpers,
>>
>> I'm Midori Kato. I'm working on the DCTCP implementation in the FreeBSD with
>> Lars Eggert. I mail you because I would like to ask you a code review and
>> testing. The attached patch is not good enough to test our code. Please give
>> me your message. I will send an ECN marking implmenetation in dummynet and
>> test scripts personally to you.
> Midori,
>
> First thing I noticed in your dctcp.patch is that you are dropping
> r256920 which adds a new argument tlen to DELAY_ACK() macro. I also
> see you removed and re-added that macro definition without any changes
> to it.
>
> Is that intentional? If not, can you please fix that and resend the patch?
>
> It is usually a good idea to work on -HEAD for such things so
> patching/committing is easier.
>
> cheers,
> Hiren
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"