From owner-freebsd-ports@freebsd.org Fri May 18 18:20:05 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2172EB0DF7 for ; Fri, 18 May 2018 18:20:04 +0000 (UTC) (envelope-from lists@opsec.eu) Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 740A482D42 for ; Fri, 18 May 2018 18:20:04 +0000 (UTC) (envelope-from lists@opsec.eu) Received: from pi by home.opsec.eu with local (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fJjz3-0003nC-Kr; Fri, 18 May 2018 20:20:05 +0200 Date: Fri, 18 May 2018 20:20:05 +0200 From: Kurt Jaeger To: Eitan Adler Cc: "John W. O'Brien" , FreeBSD Ports Subject: Re: Practice of "Sponsored by" in commit messages Message-ID: <20180518182005.GG37752@home.opsec.eu> References: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> <732c3f40-1765-6883-dbec-f5c77db8e30c@saltant.com> <7b14a5c4-7320-8f5e-b8c3-f49809caf9e5@saltant.com> <20180518041501.GF37752@home.opsec.eu> <31190803-e6ba-428b-0954-341dad2f1916@saltant.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 18:20:05 -0000 Hi! > >>>> The FreeBSD project could help by asking committers to qualify > >>>> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, > >>>> in way that is equivalent to the way that the actual work itself is > >>>> customarily attributed. > >>> This sounds reasonable, so I suggest that you submit a > >>> patch to the ports handbook that describes it for maintainers > >>> and committers. > >> One thing to note: FreeBSD has a custom patch to subversion to detect > >> "ORGANIZATION_NAME" and automatically append it to the default > >> template. This is likely why its getting added in unexpected places. > > How do you think I should handle that in my forthcoming doc patch? Is > > there a related bug I should file against services? > Its a client side patch of the subversion binary. I'm not sure the > best way to handle it beyond perhaps changing the template a bit? What change would be needed ? There's already a Sponsored by field ? The custom patch is here: https://svnweb.freebsd.org/ports/head/devel/subversion/files/extra-patch-fbsd-template?revision=411397&view=markup -- pi@opsec.eu +49 171 3101372 2 years to go !