Date: Fri, 03 Feb 2023 00:06:40 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: fb53e7adaf5b - main - tarfs: Fix 32-bit build. Message-ID: <86o7qb4qgv.fsf@ltc.des.no> In-Reply-To: <7AB1A313-19CD-4A37-BB7D-22BD384BE327@FreeBSD.org> (Dimitry Andric's message of "Fri, 3 Feb 2023 00:04:20 %2B0100") References: <202302022039.312KdedK078659@gitrepo.freebsd.org> <7AB1A313-19CD-4A37-BB7D-22BD384BE327@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dimitry Andric <dim@FreeBSD.org> writes: > This be just nitpicking, but the ino and nlink fields are typically > defined as int64_t and uint64_t, so these should be printed as such. > > Since PRId64 and PRIu64 are apparently frowned upon, the usual solution > is to cast everything to intmax_t or uintmax_t, and use %j for the > modifier. An even simpler solution is to remove the code since I just realized it's unused :) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86o7qb4qgv.fsf>