From owner-svn-ports-all@FreeBSD.ORG  Mon Nov  5 05:48:57 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 51F08AC8;
 Mon,  5 Nov 2012 05:48:57 +0000 (UTC)
 (envelope-from ohauer@FreeBSD.org)
Received: from p578be941.dip0.t-ipconnect.de (p578be941.dip0.t-ipconnect.de
 [87.139.233.65])
 by mx1.freebsd.org (Postfix) with ESMTP id 044248FC14;
 Mon,  5 Nov 2012 05:48:57 +0000 (UTC)
Received: from [192.168.0.100] (cde1100.uni.vrs [192.168.0.100])
 (Authenticated sender: ohauer)
 by p578be941.dip0.t-ipconnect.de (Postfix) with ESMTPSA id 9B81B208EE;
 Mon,  5 Nov 2012 06:48:45 +0100 (CET)
Message-ID: <5097534E.8030604@FreeBSD.org>
Date: Mon, 05 Nov 2012 06:49:02 +0100
From: Olli Hauer <ohauer@FreeBSD.org>
User-Agent: Mozilla/5.0 (Windows NT 5.1;
 rv:16.0) Gecko/20121026 Thunderbird/16.0.2
MIME-Version: 1.0
To: Gerald Pfeifer <gerald@pfeifer.com>
Subject: Re: Remove unnecessary change to Mk/bsd.port.mk (: svn commit: r303619
 - head/Mk)
References: <201209032047.q83Kl1dl041630@svn.freebsd.org>
 <alpine.LNX.2.00.1209041827470.4718@trevally.site>
 <alpine.LNX.2.00.1211041507330.2266@tuna.site>
In-Reply-To: <alpine.LNX.2.00.1211041507330.2266@tuna.site>
X-Enigmail-Version: 1.4.5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, fjoe@FreeBSD.org, svn-ports-all@freebsd.org,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2012 05:48:57 -0000

On 2012-11-04 15:09, Gerald Pfeifer wrote:
> I understand Mk/bsd.port.mk is not applicable for maintainer 
> timeouts or I would have gone ahead and committed the patch
> below.
> 
> Can you please have a look?
> 
> Thanks,
> Gerald
> 
> On Wed, 5 Sep 2012, Gerald Pfeifer wrote:
>>> +CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
>>> +.endif
>>
>> Really?
>>
>> Something looks fundamentally wrong if you have to do this under
>> .if defined(USE_READLINE), at least past
>>
>>   r270411 | erwin | 2011-03-07 07:32:05 +0000 (Mon, 07 Mar 2011) | 5 lines
>>
>>   Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV
>>
>>   PR:             153625
>>   Submitted by:   gerald
>>
>> How about the patch below?
>>
>> Gerald
>>
>> Index: bsd.port.mk
>> ===================================================================
>> --- bsd.port.mk	(revision 303674)
>> +++ bsd.port.mk	(working copy)
>> @@ -1708,7 +1708,6 @@
>>  LIB_DEPENDS+=	readline.6:${PORTSDIR}/devel/readline
>>  CPPFLAGS+=		-I${LOCALBASE}/include
>>  LDFLAGS+=		-L${LOCALBASE}/lib -lreadline
>> -CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
>>  .endif
>>  .endif
>>  
> 

Maybe fjoe@ can explain why CONFIGURE_ENV was placed here.
The line was part of PR 162995.