Date: Sun, 6 Mar 2016 13:24:58 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Wen Heping <wen@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r410226 - in head/security/py-pynacl: . files Message-ID: <b7777dc3-07e1-1723-d70b-4225294421c6@FreeBSD.org> In-Reply-To: <201603060214.u262E6qw060638@repo.freebsd.org> References: <201603060214.u262E6qw060638@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/03/2016 1:14 PM, Wen Heping wrote:
>
> -BUILD_DEPENDS= ${LOCALBASE}/lib/libnacl.a:${PORTSDIR}/security/nacl \
> - ${PYTHON_PKGNAMEPREFIX}cffi>0:${PORTSDIR}/devel/py-cffi
> -RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}cffi>0:${PORTSDIR}/devel/py-cffi
> +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}cffi>0:${PORTSDIR}/devel/py-cffi \
> + ${PYTHON_PKGNAMEPREFIX}six>0:${PORTSDIR}/devel/py-six
> +BUILD_DEPENDS= ${RUN_DEPENDS}
This is likely incorrect, both in terms of it's assignment and that six
is not a BUILD_DEPENDS. It's better to explicitly list BUILD_DEPENDS,
even if it means duplicating some of the entries of RUN_DEPENDS
> +LIB_DEPENDS= libsodium.so:${PORTSDIR}/security/libsodium
>
> USES= python
> USE_PYTHON= autoplist distutils
> -NO_ARCH= yes
> +MAKE_ENV+= SODIUM_INSTALL=system
> +CFLAGS+= -I ${LOCALBASE}/include
>
Do we know what why CFLAGS is needed and why wasn't it needed before?
Also use USES=localbase instead
./koobs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b7777dc3-07e1-1723-d70b-4225294421c6>