Date: Wed, 26 Feb 2020 22:52:56 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Andreas Kempe <kempe@lysator.liu.se> Cc: Konstantin Belousov <kib@freebsd.org>, Meny Yossefi <menyy@mellanox.com>, freebsd-infiniband@freebsd.org Subject: Re: [PATCH]: ipoib with mlx4 initialisation ordering Message-ID: <2226834e-4184-a581-87bb-3b8ce6c184da@selasky.org> In-Reply-To: <20200226213022.GG22659@moira.hest-guild.se> References: <20200222004838.GA22659@moira.hest-guild.se> <9d76992b-6ba4-2419-61ff-5035aa45e597@selasky.org> <20200224194608.GC22659@moira.hest-guild.se> <16883d49-3cc0-d9cc-0877-46f811eeb8f1@selasky.org> <20200226210554.GE22659@moira.hest-guild.se> <e2bcedd2-f2db-4d5d-453f-b59f8d7e186e@selasky.org> <20200226213022.GG22659@moira.hest-guild.se>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-02-26 22:30, Andreas Kempe wrote: > On Wed, Feb 26, 2020 at 10:08:09PM +0100, Hans Petter Selasky wrote: >> On 2020-02-26 22:05, Andreas Kempe wrote: >>> +module_exit_order(ipoib_cleanup_module, SI_ORDER_FIRST); >> >> Try: >> >> module_exit_order(ipoib_cleanup_module, SI_ORDER_FOURTH); >> > > Tried it, but the machine still hung. See patch: > > Index: sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c > =================================================================== > --- sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c (revision 356611) > +++ sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c (working copy) > @@ -1739,7 +1739,7 @@ > } > > module_init(ipoib_init_module); > -module_exit(ipoib_cleanup_module); > +module_exit_order(ipoib_cleanup_module, SI_ORDER_FOURTH); > > static int > ipoib_evhand(module_t mod, int event, void *arg) > >> >> Fourth is first, >> >> first is last. >> >> for exit. >> > I haven't yet found time to reproduce this issue. Possibly you're right that the list order matters. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2226834e-4184-a581-87bb-3b8ce6c184da>