From owner-freebsd-current@FreeBSD.ORG  Tue Oct 23 13:14:59 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 65E13178
 for <freebsd-current@freebsd.org>; Tue, 23 Oct 2012 13:14:59 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200])
 by mx1.freebsd.org (Postfix) with ESMTP id D17818FC14
 for <freebsd-current@freebsd.org>; Tue, 23 Oct 2012 13:14:57 +0000 (UTC)
Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1])
 by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q9NDF2cv045880;
 Tue, 23 Oct 2012 16:15:02 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1])
 by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q9NDEoda023859;
 Tue, 23 Oct 2012 16:14:50 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
Received: (from kostik@localhost)
 by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q9NDEoKc023858;
 Tue, 23 Oct 2012 16:14:50 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to
 kostikbel@gmail.com using -f
Date: Tue, 23 Oct 2012 16:14:50 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Svatopluk Kraus <onwahe@gmail.com>
Subject: Re: i386 pmap - missing sched_pin()?
Message-ID: <20121023131450.GU35915@deviant.kiev.zoral.com.ua>
References: <CAFHCsPXNnm9c1FL=9+2k6X6O1qfRQPRVybueM5xwdbdvONj1jg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="pdpX56ILVjuiN9xp"
Content-Disposition: inline
In-Reply-To: <CAFHCsPXNnm9c1FL=9+2k6X6O1qfRQPRVybueM5xwdbdvONj1jg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00
 autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
 skuns.kiev.zoral.com.ua
Cc: freebsd-current@freebsd.org, Alan Cox <alc@rice.edu>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2012 13:14:59 -0000


--pdpX56ILVjuiN9xp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 23, 2012 at 02:36:07PM +0200, Svatopluk Kraus wrote:
> Hi,
>=20
>    I'm just syncing my ARM pmap code (base on i386 one) with current
> i386 pmap code. It looks that sched_pin() is missing after successful
> rw_try_wlock() in pmap_protect().

Yes, you are right, I think. The following patch takes care of it.

diff --git a/sys/i386/i386/pmap.c b/sys/i386/i386/pmap.c
index ac087f6..b9033da 100644
--- a/sys/i386/i386/pmap.c
+++ b/sys/i386/i386/pmap.c
@@ -3221,6 +3221,7 @@ resume:
 						PMAP_UNLOCK(pmap);
 						goto resume;
 					}
+					sched_pin();
 				}
 				if (!pmap_demote_pde(pmap,
 				    &pmap->pm_pdir[pdirindex], sva)) {

--pdpX56ILVjuiN9xp
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)

iEYEARECAAYFAlCGmEoACgkQC3+MBN1Mb4jyCwCfX+NZhhcWOuP9mBJXcj76r5re
WksAn20ziOLCTOwDNEwFEHivqEdjpZsJ
=Zy23
-----END PGP SIGNATURE-----

--pdpX56ILVjuiN9xp--