From nobody Fri May 22 22:35:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gMg8G6myqz6dfrH; Fri, 22 May 2026 22:35:10 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gMg8G5QBLz3rWB; Fri, 22 May 2026 22:35:10 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779489310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gp2puj9Jhwz8PZLmihEH0BP6PmBEgQpE3g/yJc6chTY=; b=m6rsjQ0wS4tuXPcGtZz2JXc+7A7a5NUiSwc6ObuFCpaQBbPxnPAnOcvYWzqo/eS0nGkbTr PwxYBW+5UHtivu3b41p0wFEKWg4usMwKurWm66ib5lVxIHDR2vY5osXdXQw4Rh6dTBZwjh 4PeIP0rFEY4a1eXsg3+ZatRxKAHDjfWcvVS/mV2RKO5LFxqS58qt9Yrgae/cmD0wphbtM/ JiSUXetlx4JhMUq29syZdrEEcGLoVuMFDZlAwNt5t2HXbrOowvbaIxGAZZLXGFmAcUjOgr sTkTAJahFzDIQ0DIUrLUN6PlyLr7LhwNroJ7LR0hNp7M8jBnBfXXA4UQYcU4Cg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779489310; a=rsa-sha256; cv=none; b=JwIYsogPHejM6qQFgBaQqtYhOjypg55yPpMbFWQ/RegnfMjwvIFzJ/uL8hn1JOpEfVvQBb JhkjPUOxEK0Xshpfl+7qs3t8gfkw4g2GPg0uX9Jx/N+WIZFs/7rUDIiltC5oB8Jp/xSQkh Xr3/899HxE/6XDARvJyuRA8Wgy6t870ZN27Y5aOt1I7RyO+fhFw3erXOb2lWj4/TldrVl4 gaSir6yMSI+K8vBeC3FfJ8HJsXEYmZuf69yt82qLlje33bZNkyFMSLE7SaeKqcfVm2xCK6 O3QPpQ4YaMGXsLfmkp1538/u+SGKdMBg/0WTm6GLo1xLUBl8Olzb3m3jbe4R8A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779489310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gp2puj9Jhwz8PZLmihEH0BP6PmBEgQpE3g/yJc6chTY=; b=mup96aTCJXgLXYYGW6Hvk5X6v460z/zs+6ta/Z2pqjaaen5c6+iisVK4VATDxjYDeIvxFl w1ylal6T6H6QwPJVPyYv8Eo8P9M2HW77BAxGceiQjm6GKm/MGdt8nQnqWQBIhSHMkiTjin qPUkgoVTT4/kcKxoo60nVCGZIwi0fgHj3jLg5LQ8ywP6CXOtYsynS/A6vfKCBUvcbNPl3z xY5QgJiYswKYPUdxzdaNxlKAP3lyj3nEkH9j/jBf0+HJhkY6rf6277fF+JOryy+uvLiUv9 AAToX9/eleVvqLCaRq/5Clok7t3Tt7XTOaIdWpNb0KeqOB6ej/rKo7g7rrf9VA== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gMg8G3xY1z4fb; Fri, 22 May 2026 22:35:10 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 51222A64805; Fri, 22 May 2026 22:34:44 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id DF35A2D029E9; Fri, 22 May 2026 22:35:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id XXltETHnsvPT; Fri, 22 May 2026 22:35:07 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id CA97C2D029D8; Fri, 22 May 2026 22:35:07 +0000 (UTC) Date: Fri, 22 May 2026 22:35:07 +0000 (UTC) From: "Bjoern A. Zeeb" To: Mark Johnston cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 36b855f18925 - main - amd64/vmm: Lock global PCI passthrough structures In-Reply-To: Message-ID: <55o37qso-91n9-8rns-s584-3o2pp736105p@serrofq.bet> References: <69860b30.3f83f.acb567e@gitrepo.freebsd.org> <21416977-p363-rs27-90n6-qq2o931r4ps5@mnoonqbm.arg> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Fri, 22 May 2026, Mark Johnston wrote: >> There's a bug here. That should be return (error). That's been breaking >> pci passthru since February. I cannot imagine how no one noticed this in >> 3 months? > > Fixed in commit b13335331092, thanks. > > If I'm reading the bhyve code correctly, this is "cosmetic": the > libvmmapi wrapper for this operation is vm_unmap_pptdev_mmio(), called > in bhyve's passthru_mmio_map(). When the ioctl fails, > passthru_mmio_map() prints that warning and returns an error to the > caller... and all callers ignore it. I think that was true even before > my refactoring in commit 86150ed98b790. > > How exactly is passthru broken for you? Was goingt o say see virtualization@ but maybe it's not broken as such as I am fighting the next issue. After fixing the ENOENT locally and the errors (or warnings as you say) being gone, which I thought may be the cause preventing the next bit, I am still not getting a virtio-net device to netboot the guest. The tap interface is there and also gets connected but EFI says there is no device to boot from. I am still trying to debug that. Help will be appreciated :) -- Bjoern A. Zeeb r15:7