From owner-freebsd-current@FreeBSD.ORG  Tue Sep 15 13:17:04 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 07D441065670;
	Tue, 15 Sep 2009 13:17:04 +0000 (UTC)
	(envelope-from jh@saunalahti.fi)
Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi
	[195.197.172.116])
	by mx1.freebsd.org (Postfix) with ESMTP id B8CF88FC1E;
	Tue, 15 Sep 2009 13:17:03 +0000 (UTC)
Received: from a91-153-125-115.elisa-laajakaista.fi
	(a91-153-125-115.elisa-laajakaista.fi [91.153.125.115])
	by gw02.mail.saunalahti.fi (Postfix) with SMTP id 262A5139B92;
	Tue, 15 Sep 2009 16:16:54 +0300 (EEST)
Date: Tue, 15 Sep 2009 16:16:54 +0300
From: Jaakko Heinonen <jh@saunalahti.fi>
To: Craig Rodrigues <rodrigc@crodrigues.org>
Message-ID: <20090915131654.GA2369@a91-153-125-115.elisa-laajakaista.fi>
References: <20090908202553.GA1368@mr-happy.com>
	<200909090902.34055.mel.flynn+fbsd.current@mailing.thruhere.net>
	<20090910091329.GA2726@a91-153-125-115.elisa-laajakaista.fi>
	<200909140302.03003.mel.flynn+fbsd.current@mailing.thruhere.net>
	<20090914173208.GA4273@a91-153-125-115.elisa-laajakaista.fi>
	<20090915040032.GA68823@crodrigues.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090915040032.GA68823@crodrigues.org>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: Mel Flynn <mel.flynn+fbsd.current@mailing.thruhere.net>,
	freebsd-current@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org>,
	Jeff Blank <jfb@mr-happy.com>
Subject: Re: 8.0-BETA4 panic: ffs_sync: rofs mod
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Sep 2009 13:17:04 -0000


Hi,

On 2009-09-15, Craig Rodrigues wrote:
> Instead of using your proposed patch, could you try this patch?

Unfortunately the patch doesn't help. After the command

	# mount -o ro,rw /dev/md0 /mnt

active string options for the mount point are ro, noro, fstype, fspath,
from and errmsg. Again it blows on update mount because of the active
"ro" option.

I am also worried about using "noro" instead of "rw". At least zfs seem
to set and test for "rw" option. (Grep for MNTOPT_RW under sys/cddl.)

I have extended ddb(4) "show mount" command to print active string
options to ease debugging. The change is below if someone is interested.

%%%
Index: sys/kern/vfs_subr.c
===================================================================
--- sys/kern/vfs_subr.c	(revision 193492)
+++ sys/kern/vfs_subr.c	(working copy)
@@ -2762,6 +2762,7 @@
 DB_SHOW_COMMAND(mount, db_show_mount)
 {
 	struct mount *mp;
+	struct vfsopt *opt;
 	struct statfs *sp;
 	struct vnode *vp;
 	char buf[512];
@@ -2867,6 +2868,18 @@
 	}
 	db_printf("    mnt_kern_flag = %s\n", buf);
 
+	db_printf("    mnt_opt = ");
+	opt = TAILQ_FIRST(mp->mnt_opt);
+	if (opt != NULL) {
+		db_printf("%s", opt->name);
+		opt = TAILQ_NEXT(opt, link);
+		while (opt != NULL) {
+			db_printf(", %s", opt->name);
+			opt = TAILQ_NEXT(opt, link);
+		}
+	}
+	db_printf("\n");
+
 	sp = &mp->mnt_stat;
 	db_printf("    mnt_stat = { version=%u type=%u flags=0x%016jx "
 	    "bsize=%ju iosize=%ju blocks=%ju bfree=%ju bavail=%jd files=%ju "
%%%

-- 
Jaakko