Date: Fri, 13 Jan 2017 13:33:22 +0100 From: "Carlos J. Puga Medina" <cpm@FreeBSD.org> To: Tomoaki AOKI <junchoon@dec.sakura.ne.jp>, svn-ports-head@freebsd.org Subject: Re: Fw: Re: svn commit: r431339 - head/www/chromium Message-ID: <1484310802.1425.1.camel@FreeBSD.org> In-Reply-To: <20170113154515.028ab8592c271164e8e2083e@dec.sakura.ne.jp> References: <20170113154515.028ab8592c271164e8e2083e@dec.sakura.ne.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-FzFZzLf7xPrfc+USvkNT
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Fri, 2017-01-13 at 15:45 +0900, Tomoaki AOKI wrote:
> Hi!
> Resent as missingly sent res to improper ML (freebsd-ports).
> It should be unclear there. Sigh...
>=20
>=20
> Begin forwarded message:
>=20
> Date: Fri, 13 Jan 2017 15:29:06 +0900
> From: Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
> To: freebsd-ports@freebsd.org
> Cc: cpm@FreeBSD.org
> Subject: Re: svn commit: r431339 - head/www/chromium
>=20
>=20
> Hi!
>=20
> Can we assume all -head users update src at least "per month" basis?
> If so, no problem.
>=20
> If not, as __FreeBSD_version 1200018 came on Dec 7 15:04:22 2016 UTC
> at
> r309676, users sticking on src before this should need
> EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-old.
>=20
> This case, version check portion for 11 and 12 should be as below.
>=20
>=20
> .if ${OSVERSION} < 1200017
> .if ${OSVERSION} > 1100507 && ${OSVERSION} < 1200000
> EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-new
> .else
> EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-old
> .endif
> .else
> EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-new
> .endif
>=20
>=20
To simplify the OSVERSION checks:
.if ${OSVERSION} < 1200017 || (${OSVERSION} >=3D 1100507 && ${OSVERSION}
< 1200000)
EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-new
.else
EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-old
.endif
> This could be restored with yours after stable/12 is branched.
>=20
> Or making ports/UPDATING entry for -head users to update to latest
> base (at least after r309676) first before updating chromium could
> be enough.
>=20
> Regards.
>=20
> >=20
> > Author: cpm
> > Date: Fri Jan 13 03:18:05 2017
> > New Revision: 431339
> > URL: https://svnweb.freebsd.org/changeset/ports/431339
> >=20
> > Log:
> > =C2=A0 - Wrap the entire block with OPSYS check
> > =C2=A0=C2=A0
> > =C2=A0 Reported by: marino
> > =C2=A0 MFH: 2017Q1 (blanket)
> >=20
> > Modified:
> > =C2=A0 head/www/chromium/Makefile
> >=20
> > Modified: head/www/chromium/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- head/www/chromium/Makefile Fri Jan 13 02:41:25 2017
> =C2=A0(r431338)
> >=20
> > +++ head/www/chromium/Makefile Fri Jan 13 03:18:05
> 2017 (r431339)
> >=20
> > @@ -187,15 +187,17 @@ GN_ARGS+=3D
> is_clang=3Dtrue
> >=20
> > =C2=A0EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-clang
> > =C2=A0.endif
> > =C2=A0
> > -.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1100508
> > +.if ${OPSYS} =3D=3D FreeBSD
> > +.if ${OSVERSION} < 1100508
> > =C2=A0EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-old
> > =C2=A0.else
> > =C2=A0EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-new
> > =C2=A0.endif
> > =C2=A0
> > -.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1100000
> > +.if ${OSVERSION} < 1100000
> > =C2=A0EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-10
> > =C2=A0.endif
> > +.endif
> > =C2=A0
> > =C2=A0.if ! ${PORT_OPTIONS:MKERBEROS}
> > =C2=A0GN_ARGS+=3D use_kerberos=3Dtrue
> --=C2=A0
> Tomoaki AOKI=C2=A0=C2=A0=C2=A0=C2=A0<junchoon@dec.sakura.ne.jp>
>=20
>=20
--=20
Carlos Jacobo Puga Medina <cpm@FreeBSD.org>
PGP fingerprint =3D C60E 9497 5302 793B CC2D BB89 A1F3 5D66 E6D0 5453
--=-FzFZzLf7xPrfc+USvkNT
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iQGTBAABCgB9FiEExg6Ul1MCeTvMLbuJofNdZubQVFMFAlh4yRNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2
MEU5NDk3NTMwMjc5M0JDQzJEQkI4OUExRjM1RDY2RTZEMDU0NTMACgkQofNdZubQ
VFNgsgf/bkvM0IMfrNfrR8M++B06tgfycY25HdW0jPBGLqG7SgYIwlzDQasfSv+g
NsC9BUpeCFncsRHEup4EQKW+kwF8VEQNz77/O/40dX5fmFrT7eygOey4yz61VUfd
UEMlGWrbpcgd7w/Lc0TGKMO+MwTCF8PCJllR+Ra5n/Y3O2vd/lqVaVMCOB4T0Y0C
rWFbUYWlToJw1CEBE/yIJSmzBKXaKs3/Jv0CCYOYEhnPyJ0DW9NLrdBQD1Hm0TXM
cAVPYAJPJVqN6kOrw41OPC47myulFFnSUHVo/SwiTlXGd6oOXljn5jBa48k+9Gm3
OYhNzlrbIEk17M5tdAda9HZgB7V4QA==
=gydi
-----END PGP SIGNATURE-----
--=-FzFZzLf7xPrfc+USvkNT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1484310802.1425.1.camel>