From owner-svn-src-all@FreeBSD.ORG Thu Jun 4 19:09:16 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 910251065673; Thu, 4 Jun 2009 19:09:16 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206192061.chello.pl [87.206.192.61]) by mx1.freebsd.org (Postfix) with ESMTP id C8C728FC17; Thu, 4 Jun 2009 19:09:15 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 6203745B26; Thu, 4 Jun 2009 21:09:14 +0200 (CEST) Received: from localhost (chello087206192061.chello.pl [87.206.192.61]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id F00E04569A; Thu, 4 Jun 2009 21:09:08 +0200 (CEST) Date: Thu, 4 Jun 2009 21:09:12 +0200 From: Pawel Jakub Dawidek To: Robert Watson Message-ID: <20090604190912.GB1705@garage.freebsd.pl> References: <200906041030.n54AUIh4084623@svn.freebsd.org> <20090604190709.GA1705@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V0207lvV8h4k8FAm" Content-Disposition: inline In-Reply-To: <20090604190709.GA1705@garage.freebsd.pl> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193433 - head/sys/fs/devfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2009 19:09:17 -0000 --V0207lvV8h4k8FAm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 04, 2009 at 09:07:09PM +0200, Pawel Jakub Dawidek wrote: > On Thu, Jun 04, 2009 at 10:30:18AM +0000, Robert Watson wrote: > > Author: rwatson > > Date: Thu Jun 4 10:30:18 2009 > > New Revision: 193433 > > URL: http://svn.freebsd.org/changeset/base/193433 > >=20 > > Log: > > Re-add opt_mac.h include, which is required in order for MNT_MULTILAB= EL > > to be set properly on devfs. Otherwise, it isn't possible to set lab= els > > on /dev nodes. > > =20 > > Reported by: Sergio Rodriguez > > MFC after: 3 days >=20 > I'm afraid that's not the only case: >=20 > http://people.freebsd.org/~pjd/patches/opt_mac.patch I forgot to mention that even a compile test wasn't made and for dev/cxgb/ulp/tom/cxgb_cpl_io.c including opt_mac.h will trigger this: #ifdef MAC #error "no MAC support" #endif --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --V0207lvV8h4k8FAm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKKBvXForvXbEpPzQRAnMPAJ9VdvjtbDPYP6I/yjMJ4Im5NuEIGwCeOzTA A5kTbUH03kX3qcWku5dIYG4= =OXBh -----END PGP SIGNATURE----- --V0207lvV8h4k8FAm--